Enhancements for db_securityadmin fixed role #3344
Conversation
Signed-off-by: Harsh Lunagariya <[email protected]>
Signed-off-by: Harsh Lunagariya <[email protected]>
Pull Request Test Coverage Report for Build 12595724260Details
💛 - Coveralls |
| ALTER ROLE babel_5135_r1 ADD MEMBER babel_5135_dbsecadmin_u1; | ||
| GO | ||
|
|
||
| ALTER ROLE babel_5135_r1 DROP MEMBER babel_5135_dbsecadmin_u1; | ||
| GO |
There was a problem hiding this comment.
Why is this test repeated? It is already there at line number 178 and 181.
There was a problem hiding this comment.
In this scenario, we wanted to test whether we can add current user as member of babel_5135_r1 (when it is member of db_owner).
| ALTER ROLE db_owner ADD MEMBER babel_5135_r1; | ||
| GO | ||
| ~~ERROR (Code: 33557097)~~ | ||
|
|
||
| ~~ERROR (Message: Adding database roles to db_owner is not currently supported in Babelfish)~~ |
There was a problem hiding this comment.
The comment above says it should be able ALTER the membership but here we are getting an error. Is this error expected? If yes then we should chose a different test case in which current user is able to ALTER the membership of db_owner.
There was a problem hiding this comment.
This is added for future when we add support of adding database roles as member of db_owner. Will add a comment regarding it.
| ALTER ROLE db_owner DROP MEMBER babel_5135_r1; | ||
| GO | ||
| ~~ERROR (Code: 33557097)~~ | ||
|
|
||
| ~~ERROR (Message: Dropping database roles from db_owner is not currently supported in Babelfish)~~ |
There was a problem hiding this comment.
Same as above, I don't think we intend to test this error in this scenario.
There was a problem hiding this comment.
This is added for future when we add support of adding database roles as member of db_owner. Will add a comment regarding it.
Signed-off-by: Harsh Lunagariya <[email protected]>
rishabhtanwar29
merged commit 0b77a7a
into
babelfish-for-postgresql:BABEL_5_X_DEV
…l#3344) Allow UPDATE on sequence and allow add/dropping current user(which is member of db_securityadmin) from user-defined database roles. Added some more tests. Task: BABEL-5135 Signed-off-by: Harsh Lunagariya <[email protected]>
Description
Allow UPDATE on sequence and allow add/dropping current user(which is member of db_securityadmin) from user-defined database roles. Added some more tests.
Issues Resolved
BABEL-5135
Test Scenarios Covered
Use case based -
Added
Boundary conditions -
Arbitrary inputs -
Negative test cases -
Minor version upgrade tests -
Major version upgrade tests -
Performance tests -
Tooling impact -
Client tests -
Check List
By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.