Improve performance of sys.sp_column_privileges by removing an unutilized check

[shalinilohia50]

Description

Improve performance of sys.sp_column_privileges by removing an unutilized check.

Issues Resolved

Task: BABEL-5353
Signed-off-by: Shalini Lohia [email protected]

Test Scenarios Covered

Performance Testing

query	Execution time before (ms)	Execution time after (ms)
EXEC sp_column_privileges @table_name = 'db1_table3'	2903	1453
EXEC sp_column_privileges @table_name = 'db1_table3', @table_qualifier = 'db1', @COLUMN_NAME='column1'	2900	1442
CREATE PROCEDURE usp_GetColumnPrivileges @TableName NVARCHAR(128) AS begin EXEC sys.sp_column_privileges @table_name = @TableName; end ; usp_GetColumnPrivileges @TableName = 'db1_table3';	2893	1454

• Use case based -

• Boundary conditions -

• Arbitrary inputs -

• Negative test cases -

• Minor version upgrade tests -

• Major version upgrade tests -

• Performance tests -

• Tooling impact -

• Client tests -

Check List

• Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.

For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[coveralls]

Pull Request Test Coverage Report for Build 12616663846

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• 3 unchanged lines in 2 files lost coverage.
• Overall coverage decreased (-0.002%) to 74.865%

---

Files with Coverage Reduction	New Missed Lines	%
contrib/babelfishpg_tds/src/backend/tds/tdsutils.c	1	73.66%
contrib/babelfishpg_tds/src/backend/tds/tdscomm.c	2	76.03%

Totals
Change from base Build 12596818602:	-0.002%
Covered Lines:	46600
Relevant Lines:	62245

---

💛 - Coveralls