Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve performance of sys.sp_column_privileges by removing an unutilized check #3349

Conversation

shalinilohia50
Copy link
Contributor

@shalinilohia50 shalinilohia50 commented Jan 5, 2025

Description

Improve performance of sys.sp_column_privileges by removing an unutilized check.

Cherry-picked from #3348

Issues Resolved

Task: BABEL-5353
Signed-off-by: Shalini Lohia [email protected]

Test Scenarios Covered

Performance Testing

query Execution time before (ms) Execution time after (ms)
EXEC sp_column_privileges @table_name = 'db1_table3' 2903 1453
EXEC sp_column_privileges @table_name = 'db1_table3', @table_qualifier = 'db1', @COLUMN_NAME='column1' 2900 1442
CREATE PROCEDURE usp_GetColumnPrivileges @TableName NVARCHAR(128) AS begin EXEC sys.sp_column_privileges @table_name = @TableName; end ; usp_GetColumnPrivileges @TableName = 'db1_table3'; 2893 1454
  • Use case based -

  • Boundary conditions -

  • Arbitrary inputs -

  • Negative test cases -

  • Minor version upgrade tests -

  • Major version upgrade tests -

  • Performance tests -

  • Tooling impact -

  • Client tests -

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 12616694469

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.003%) to 74.504%

Totals Coverage Status
Change from base Build 12594699864: 0.003%
Covered Lines: 46344
Relevant Lines: 62203

💛 - Coveralls

@thephantomthief thephantomthief self-requested a review January 6, 2025 14:30
Copy link
Contributor

@jsudrik jsudrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@jsudrik jsudrik merged commit bb29bcf into babelfish-for-postgresql:BABEL_5_0_STABLE Jan 6, 2025
44 checks passed
@shalinilohia50 shalinilohia50 deleted the jira-5353-fix-5stable branch January 6, 2025 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants