Fix the nvarchar-varbinary casting (#3072) #3358
Open
+4,212
−684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PROBLEM: while casting nvarchar to varbinary we were considering the UTF8 encoding as input encoding in Babelfish where as in TSQL we use UTF16 encoding fir nvarchar irrespective of input encoding. RCA: we were considering varchar and nvarchar as same, whereas we should use input encoding for varchar and UTF16 encoding for nvarchar. FIX: So we need to identify that if the input is nvarchar then we will do the UTF16 encoding. For a casting like nvarchar->varbinary->nvarchar, now since for the casting we are encoding the input string into UTF16 encoding via function nvarcharvarbinary, so while converting varbinary-> nvarchar we will use the function varbinarynvarchar where we will convert UTF16 encoding to UTF8 with null padding. So we created a function nvarcharvarbinary and varbinarynvarchar to handle nvarchar<-> varbinary to and fro casting. And for this casting we have specifically applied a condition that we will not convert the datatype to basetype before choosing the casting function Task: BABEL-4891 Signed-off-by: Pranav Jain <[email protected]>
Signed-off-by: pranav jain <[email protected]>
Pull Request Test Coverage Report for Build 12670298132Details
💛 - Coveralls |
Signed-off-by: pranav jain <[email protected]>
Signed-off-by: pranav jain <[email protected]>
Signed-off-by: pranav jain <[email protected]>
Signed-off-by: pranav jain <[email protected]>
Signed-off-by: pranav jain <[email protected]>
rishabhtanwar29
approved these changes
Jan 7, 2025
rishabhtanwar29
previously approved these changes
Jan 7, 2025
Signed-off-by: pranav jain <[email protected]>
rohit01010
reviewed
Jan 7, 2025
Comment on lines
10
to
29
| CREATE OR REPLACE FUNCTION sys.nvarcharvarbinary(sys.NVARCHAR, integer, boolean) | ||
| RETURNS sys.BBF_VARBINARY | ||
| AS 'babelfishpg_common', 'nvarcharvarbinary' | ||
| LANGUAGE C IMMUTABLE STRICT PARALLEL SAFE; | ||
|
|
||
| CREATE OR REPLACE FUNCTION sys.varbinarysysnvarchar(sys.BBF_VARBINARY, integer, boolean) | ||
| RETURNS sys.NVARCHAR | ||
| AS 'babelfishpg_common', 'varbinarynvarchar' | ||
| LANGUAGE C IMMUTABLE STRICT PARALLEL SAFE; | ||
|
|
||
| CREATE OR REPLACE FUNCTION sys.binarysysnvarchar(sys.BBF_BINARY, integer, boolean) | ||
| RETURNS sys.NVARCHAR | ||
| AS 'babelfishpg_common', 'varbinarynvarchar' | ||
| LANGUAGE C IMMUTABLE STRICT PARALLEL SAFE; | ||
|
|
||
| CREATE OR REPLACE FUNCTION sys.nvarcharbinary(sys.NVARCHAR, integer, boolean) | ||
| RETURNS sys.BBF_BINARY | ||
| AS 'babelfishpg_common', 'nvarcharbinary' | ||
| LANGUAGE C IMMUTABLE STRICT PARALLEL SAFE; | ||
|
|
There was a problem hiding this comment.
why we need this change in 4.4.0--5.0.0 upgrade script ?
There was a problem hiding this comment.
It seems like cherry pick added the change of 4.4.0--4.5.0 to 4.4.0--5.0.0 automatically, without giving conflicts.
Will change this
Thanks!
Signed-off-by: pranav jain <[email protected]>
rohit01010
approved these changes
Jan 8, 2025
Signed-off-by: pranav jain <[email protected]>
Signed-off-by: pranav jain <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cherry-pick from: #3072 (reference)
PROBLEM: while casting nvarchar to varbinary we were considering the UTF8 encoding as input encoding in Babelfish where as in TSQL we use UTF16 encoding fir nvarchar irrespective of input encoding.
RCA: we were considering varchar and nvarchar as same, whereas we should use input encoding for varchar and UTF16 encoding for nvarchar.
FIX: So we need to identify that if the input is nvarchar then we will do the UTF16 encoding.
For a casting like nvarchar->varbinary->nvarchar, now since for the casting we are encoding the input string into UTF16 encoding via function nvarcharvarbinary, so while converting varbinary-> nvarchar we will use the function varbinarynvarchar where we will convert UTF16 encoding to UTF8 with null padding.
So we created a function nvarcharvarbinary and varbinarynvarchar to handle nvarchar<-> varbinary to and fro casting. And for this casting we have specifically applied a condition that we will not convert the datatype to basetype before choosing the casting function
Also added the upgrade-test-configuration
Issues Resolved
Task: [BABEL-4891]
Check List
By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.