Fix inconsistent formatting issue in convert function when converting from money to varchar #3360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… from money to varchar (babelfish-for-postgresql#3337) Description Currently when converting from money to varchar using convert function with different style values, the result is inconsistent with the formatting. This PR will address this issue by updating the logic to handle these edge cases. The issues that will get addressed in this PR are as follows Extra space is getting added in the beginning of the result when style parameter is 0 or 2. When input is 0, then 0 is missing before decimal in the result for style 0 and 2. Also for style 1 the result has $ before decimal instead of 0. For example, when converting value 0 with money datatype to varchar datatype For style 0, result is .00 For style 1, result is $.00 For style 2, result is .0000 When style is 2, and the input has more than 2 digits after decimal, then the result is getting rounded upto 2 digits after decimal, which ideally should be rounded upto 4 digits. Issues Resolved BABEL-5462 Authored-by: Rohit Bhagat [email protected] Signed-off-by: Rohit Bhagat [email protected]
Anikait143
approved these changes
Jan 6, 2025
Pull Request Test Coverage Report for Build 12631185602Details
💛 - Coveralls |
jsudrik
merged commit 414c7f2
into
babelfish-for-postgresql:BABEL_4_X_DEV
47 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently when converting from money to varchar using convert function with different style values, the result is inconsistent with the formatting. This PR will address this issue by updating the logic to handle these edge cases. The issues that will get addressed in this PR are as follows
$before decimal instead of 0. For example, when converting value 0 with money datatype to varchar datatype.00$.00.0000Cherry-picked from: #3337
Authored-by: Rohit Bhagat [email protected]
Signed-off-by: Rohit Bhagat [email protected]
Issues Resolved
BABEL-5462
Test Scenarios Covered
Use case based - YES
Boundary conditions - YES
Arbitrary inputs - NA
Negative test cases - NA
Minor version upgrade tests - YES
Major version upgrade tests - YES
Performance tests - NA
Tooling impact - NA
Client tests - YES
Check List
By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.