-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OSS-ONLY] Implementing hashcode and mode based caching #3414
base: BABEL_5_X_DEV
Are you sure you want to change the base?
[OSS-ONLY] Implementing hashcode and mode based caching #3414
Conversation
Pull Request Test Coverage Report for Build 12830872482Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
@@ -24,11 +24,11 @@ inputs: | |||
runs: | |||
using: "composite" | |||
steps: | |||
- name: Checkout, Build, and Install the Modified PostgreSQL Instance and Run Tests | |||
- name: Remake engine repository |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let us name this checkout Modified PostgreSQL for Babelfish
rm -rf ~/.ccache | ||
echo "CCACHE_KEY=" >> $GITHUB_ENV | ||
echo "SAVE_CCACHE=" >> $GITHUB_ENV | ||
echo "SAVE_CACHE_HERE=" >> $GITHUB_ENV |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let us also unset CRESTORE_KEY
key: | ||
random-random | ||
restore-keys: | ||
ccache-${{ env.CRESTORE_KEY }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question: So this will only match by Engine SHA followed by whatever sha matches for extension, so if Extension has some new code changes will the action ensure the newest version of cache for that PR is used?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if [[ ${{ github.event_name != 'pull_request' || env.SAVE_CCACHE == 1 }} == true ]]; then
echo "Cache to be Saved"
echo "SAVE_CACHE_HERE=1" >> $GITHUB_ENV
We are force saving cache for any request that isn't a PR, so a merge would trigger this.
Description
This commit implements a more efficient method of caching compilations. Cache now restored will now be guaranteed to compatible with the version and build configuration of compilations.
We will now save 5-8 mins in version upgrade and dump restore tests.
Key changes:
Task: BABEL-5564
Signed-off-by: Siddharth Sengar [email protected]
Check List
By submitting this pull request,
I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.