Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Babelfish full text files (#186) #221

Conversation

roshan0708
Copy link
Contributor

@roshan0708 roshan0708 commented Sep 27, 2023

This cherry-picks commit: 590708e which was reverted before for unblocking some issues.

These changes enhances Babelfish's Full Text Search (FTS) configurations to closely align with SQL Server's behavior. It introduces stopwords and synonym files, streamlining FTS setup and ensuring consistent functionality. By including these files directly, we simplify configuration management and eliminate potential issues with external dependencies.

Signed-off-by: Roshan Kanwar [[email protected]]

Description

[Describe what this change achieves]

Issues Resolved

This PR will fix the build issues in PR-1858

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is under the terms of the PostgreSQL license, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.

For more information on following Developer Certificate of Origin and signing off your commits, please check here.

We need to add full text configurations to make Babelfish's full text
search behaviors match more closely with SQL Server. This commit adds a
stopwords file and a synonym file that are used by Babelfish to create
its full text configurations.

Task: BABEL-4246
Signed-off-by: Robin Li <[email protected]>
Co-authored-by: Robin Li <[email protected]>
@roshan0708 roshan0708 changed the title Unrevert "Add Babelfish full text files (#186)" Add Babelfish full text files (#186) Sep 27, 2023
@forestkeeper forestkeeper merged commit 4493423 into babelfish-for-postgresql:BABEL_3_X_DEV__PG_15_X Oct 25, 2023
2 checks passed
Sairakan pushed a commit to amazon-aurora/postgresql_modified_for_babelfish that referenced this pull request Nov 16, 2023
…sh-for-postgresql#221)

We need to add full text configurations to make Babelfish's full text
search behaviors match more closely with SQL Server. This commit adds a
stopwords file and a synonym file that are used by Babelfish to create
its full text configurations.

Task: BABEL-4246
Signed-off-by: Robin Li <[email protected]>
priyansx pushed a commit to amazon-aurora/postgresql_modified_for_babelfish that referenced this pull request Nov 22, 2023
…sh-for-postgresql#221)

We need to add full text configurations to make Babelfish's full text
search behaviors match more closely with SQL Server. This commit adds a
stopwords file and a synonym file that are used by Babelfish to create
its full text configurations.

Task: BABEL-4246
Signed-off-by: Robin Li <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants