Support for Instead of Trigger On Views in Babelfish #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently Postgres does not support Instead of Trigger On Views for DML queries. On running such a query on VIEW, query rewriting substitutes view with underlying base table. Added a hook for skipping the substitution for DML query on the VIEW. This change will add support for Instaed of Triggers for DML queries when using Babelfish. Task: BABEL-2170 Signed-off-by: Deepakshi Mittal <[email protected]>
1 task
forestkeeper
reviewed
Oct 3, 2023
Task: BABEL-2170 Signed-off-by: Deepakshi Mittal <[email protected]>
deepakshi-mittal
force-pushed
the
BABEL-2170
branch
from
6aebdcd to
0be4bf6
Compare
forestkeeper
merged commit d10cc3e
into
babelfish-for-postgresql:BABEL_3_X_DEV__PG_15_X
Sairakan
pushed a commit
to amazon-aurora/postgresql_modified_for_babelfish
that referenced
this pull request
Nov 16, 2023
…ostgresql#225) * Support for Instead of Trigger On Views in Babelfish Currently Postgres does not support Instead of Trigger On Views for DML queries. On running such a query on VIEW, query rewriting substitutes view with underlying base table. Added a hook for skipping the substitution for DML query on the VIEW. This change will add support for Instaed of Triggers for DML queries when using Babelfish. Task: BABEL-2170 Signed-off-by: Deepakshi Mittal <[email protected]>
priyansx
pushed a commit
to amazon-aurora/postgresql_modified_for_babelfish
that referenced
this pull request
Nov 22, 2023
…ostgresql#225) * Support for Instead of Trigger On Views in Babelfish Currently Postgres does not support Instead of Trigger On Views for DML queries. On running such a query on VIEW, query rewriting substitutes view with underlying base table. Added a hook for skipping the substitution for DML query on the VIEW. This change will add support for Instaed of Triggers for DML queries when using Babelfish. Task: BABEL-2170 Signed-off-by: Deepakshi Mittal <[email protected]>
1 task
deepakshi-mittal
added a commit
to amazon-aurora/postgresql_modified_for_babelfish
that referenced
this pull request
Nov 27, 2023
Merged
1 task
deepakshi-mittal
added a commit
to amazon-aurora/postgresql_modified_for_babelfish
that referenced
this pull request
Nov 27, 2023
forestkeeper
pushed a commit
that referenced
this pull request
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently Postgres does not support Instead of Trigger On Views for DML queries.
On running such a query on VIEW, query rewriting substitutes view with underlying base table.
Added a hook for skipping the substitution for DML query on the VIEW.
This change will add support for Instaed of Triggers for DML queries when using Babelfish.
Task: BABEL-2170
Signed-off-by: Deepakshi Mittal [email protected]
By submitting this pull request, I confirm that my contribution is under the terms of the PostgreSQL license, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.