Correctly dump permissions for a Babelfish logical database #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rishabh Tanwar <[email protected]>
Signed-off-by: Rishabh Tanwar <[email protected]>
HarshLunagariya
approved these changes
Oct 31, 2023
HarshLunagariya
approved these changes
Nov 1, 2023
surendravishnoi
approved these changes
Nov 2, 2023
shardgupta
merged commit 4f6179b
into
babelfish-for-postgresql:BABEL_3_X_DEV__PG_15_X
2 checks passed
Sairakan
pushed a commit
to amazon-aurora/postgresql_modified_for_babelfish
that referenced
this pull request
Nov 16, 2023
…h-for-postgresql#244) Previously, we were not dumping sysadmin membership for a database user during database level dump due to which users other than sysadmin were unable to drop the restored database. This commit fixes the issue by correctly dumping role memberships for all the database roles. Additionally, refactored the code a little bit in dump_babel_utils.c Task: BABEL-4516 Signed-off-by: Rishabh Tanwar [email protected]
priyansx
pushed a commit
to amazon-aurora/postgresql_modified_for_babelfish
that referenced
this pull request
Nov 22, 2023
…h-for-postgresql#244) Previously, we were not dumping sysadmin membership for a database user during database level dump due to which users other than sysadmin were unable to drop the restored database. This commit fixes the issue by correctly dumping role memberships for all the database roles. Additionally, refactored the code a little bit in dump_babel_utils.c Task: BABEL-4516 Signed-off-by: Rishabh Tanwar [email protected]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously, we were not dumping sysadmin membership for a database
user during database level dump due to which users other than sysadmin
were unable to drop the restored database.
This commit fixes the issue by correctly dumping role memberships for all
the database roles. Additionally, refactored the code a little bit in dump_babel_utils.c
Task: BABEL-4516
Signed-off-by: Rishabh Tanwar [email protected]
Check List
By submitting this pull request, I confirm that my contribution is under the terms of the PostgreSQL license, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.