Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Instead of Trigger On Views Pg16_1 #280

Conversation

deepakshi-mittal
Copy link
Contributor

@deepakshi-mittal deepakshi-mittal commented Jan 3, 2024

Description

Currently Postgres does not support Instead of Trigger On Views for DML queries.

On running such a query on VIEW, query rewriting substitutes view with underlying base table.
Added a hook for skipping the substitution for DML query on the VIEW.

This change will add support for Instead of Triggers for DML queries when using Babelfish.

Task: BABEL-2170/BABEL-4532/BABEL-4514

Engine Pg 15 PR: #272
Extensions PG 16 PR: babelfish-for-postgresql/babelfish_extensions#2207

Issues Resolved

BABEL-2170/BABEL-4532/BABEL-4514

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is under the terms of the PostgreSQL license, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.

For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Currently Postgres does not support Instead of Trigger
On Views for DML queries.

On running such a query on VIEW, query rewriting substitutes
view with underlying base table.
Added a hook for skipping the substitution for DML
query on the VIEW.

This change will add support for Instead of Triggers
for DML queries when using Babelfish.

Task: BABEL-2170/BABEL-4532/BABEL-4514
Signed-off-by: Deepakshi Mittal <[email protected]>
@deepakshi-mittal deepakshi-mittal changed the title Babel 2170 v2 pg16 1 Support Instead of Trigger On Views Pg16_1 Jan 3, 2024
@forestkeeper forestkeeper merged commit 6f2773e into babelfish-for-postgresql:BABEL_4_X_DEV__PG_16_X Jan 3, 2024
2 checks passed
deepakshi-mittal added a commit to amazon-aurora/postgresql_modified_for_babelfish that referenced this pull request Jan 9, 2024
Currently Postgres does not support Instead of Trigger
On Views for DML queries.

On running such a query on VIEW, query rewriting substitutes
view with underlying base table.
Added a hook for skipping the substitution for DML
query on the VIEW.

This change will add support for Instead of Triggers
for DML queries when using Babelfish.

Task: BABEL-2170/BABEL-4532/BABEL-4514
Signed-off-by: Deepakshi Mittal <[email protected]>
roshan0708 pushed a commit to amazon-aurora/postgresql_modified_for_babelfish that referenced this pull request Oct 18, 2024
)

Currently Postgres does not support Instead of Trigger
On Views for DML queries.

On running such a query on VIEW, query rewriting substitutes
view with underlying base table.
Added a hook for skipping the substitution for DML
query on the VIEW.

This change will add support for Instead of Triggers
for DML queries when using Babelfish.

Task: BABEL-2170/BABEL-4532/BABEL-4514
Signed-off-by: Deepakshi Mittal <[email protected]>
roshan0708 pushed a commit to amazon-aurora/postgresql_modified_for_babelfish that referenced this pull request Oct 18, 2024
)

Currently Postgres does not support Instead of Trigger
On Views for DML queries.

On running such a query on VIEW, query rewriting substitutes
view with underlying base table.
Added a hook for skipping the substitution for DML
query on the VIEW.

This change will add support for Instead of Triggers
for DML queries when using Babelfish.

Task: BABEL-2170/BABEL-4532/BABEL-4514
Signed-off-by: Deepakshi Mittal <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants