OID Wraparound #295
Merged
OID Wraparound #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tim Chang <[email protected]> add full range of OID Remove ability to alter buffer size GUC, correct error messages Remove lc NULL check Remove references to TempVariableCache Revert "Remove lc NULL check" This reverts commit 07c28e5. Add proper check for toast tables Added comments, added OID macros Add temp table utilization warning Use correct backend for index_create workaround Add include Fix ALTER TABLE with TOAST issue Minor whitespace + comment Signed-off-by: Tim Chang <[email protected]> Ensure non-ENR temp works as expected Disable pgstat for temp tables to avoid concurrency issues Signed-off-by: Tim Chang <[email protected]> Moved new OID generation functions into extension hooks Signed-off-by: Tim Chang <[email protected]> Minor style fixes Signed-off-by: Tim Chang <[email protected]> Additional style fixed, removed obsolete vars Signed-off-by: Tim Chang <[email protected]> Remove 80% warning since it is misleading Signed-off-by: Tim Chang <[email protected]> Minor fixes Signed-off-by: Tim Chang <[email protected]> Move macro to transam for visibility Revert "Move macro to transam for visibility" This reverts commit ea15243. Add simple fetch for VAR_OID_PREFETCH
|
@timchang514 confirmed @surendravishnoi has approved the original PRs: |
lejaokri
approved these changes
Jan 17, 2024
lejaokri
merged commit 631916e
into
babelfish-for-postgresql:BABEL_4_X_DEV__PG_16_X
2 checks passed
Deepesh125
pushed a commit
to amazon-aurora/postgresql_modified_for_babelfish
that referenced
this pull request
Jan 22, 2024
…or-postgresql#295) Signed-off-by: Tim Chang <[email protected]> add full range of OID Remove ability to alter buffer size GUC, correct error messages Remove lc NULL check Remove references to TempVariableCache Revert "Remove lc NULL check" This reverts commit 07c28e5. Add proper check for toast tables Added comments, added OID macros Add temp table utilization warning Use correct backend for index_create workaround Add include Fix ALTER TABLE with TOAST issue Minor whitespace + comment Signed-off-by: Tim Chang <[email protected]> Ensure non-ENR temp works as expected Disable pgstat for temp tables to avoid concurrency issues Signed-off-by: Tim Chang <[email protected]> Moved new OID generation functions into extension hooks Signed-off-by: Tim Chang <[email protected]> Minor style fixes Signed-off-by: Tim Chang <[email protected]> Additional style fixed, removed obsolete vars Signed-off-by: Tim Chang <[email protected]> Remove 80% warning since it is misleading Signed-off-by: Tim Chang <[email protected]> Minor fixes Signed-off-by: Tim Chang <[email protected]> Move macro to transam for visibility Revert "Move macro to transam for visibility" This reverts commit ea15243. Add simple fetch for VAR_OID_PREFETCH
1 task
forestkeeper
pushed a commit
that referenced
this pull request
Jan 25, 2024
Fixes an issue with orphaned temp toast table entries. Adding toasts to ENR for temp tables. This was originally introduced as part of #295 Signed-off-by: Tim Chang <[email protected]>
roshan0708
pushed a commit
to amazon-aurora/postgresql_modified_for_babelfish
that referenced
this pull request
Oct 15, 2024
…lfish-for-postgresql#295) Signed-off-by: Tim Chang <[email protected]> add full range of OID Remove ability to alter buffer size GUC, correct error messages Remove lc NULL check Remove references to TempVariableCache Revert "Remove lc NULL check" This reverts commit 07c28e5. Add proper check for toast tables Added comments, added OID macros Add temp table utilization warning Use correct backend for index_create workaround Add include Fix ALTER TABLE with TOAST issue Minor whitespace + comment Signed-off-by: Tim Chang <[email protected]> Ensure non-ENR temp works as expected Disable pgstat for temp tables to avoid concurrency issues Signed-off-by: Tim Chang <[email protected]> Moved new OID generation functions into extension hooks Signed-off-by: Tim Chang <[email protected]> Minor style fixes Signed-off-by: Tim Chang <[email protected]> Additional style fixed, removed obsolete vars Signed-off-by: Tim Chang <[email protected]> Remove 80% warning since it is misleading Signed-off-by: Tim Chang <[email protected]> Minor fixes Signed-off-by: Tim Chang <[email protected]> Move macro to transam for visibility Revert "Move macro to transam for visibility" This reverts commit ea15243. Add simple fetch for VAR_OID_PREFETCH
roshan0708
pushed a commit
to amazon-aurora/postgresql_modified_for_babelfish
that referenced
this pull request
Oct 18, 2024
…lfish-for-postgresql#295) Signed-off-by: Tim Chang <[email protected]> add full range of OID Remove ability to alter buffer size GUC, correct error messages Remove lc NULL check Remove references to TempVariableCache Revert "Remove lc NULL check" This reverts commit 07c28e5. Add proper check for toast tables Added comments, added OID macros Add temp table utilization warning Use correct backend for index_create workaround Add include Fix ALTER TABLE with TOAST issue Minor whitespace + comment Signed-off-by: Tim Chang <[email protected]> Ensure non-ENR temp works as expected Disable pgstat for temp tables to avoid concurrency issues Signed-off-by: Tim Chang <[email protected]> Moved new OID generation functions into extension hooks Signed-off-by: Tim Chang <[email protected]> Minor style fixes Signed-off-by: Tim Chang <[email protected]> Additional style fixed, removed obsolete vars Signed-off-by: Tim Chang <[email protected]> Remove 80% warning since it is misleading Signed-off-by: Tim Chang <[email protected]> Minor fixes Signed-off-by: Tim Chang <[email protected]> Move macro to transam for visibility Revert "Move macro to transam for visibility" This reverts commit ea15243. Add simple fetch for VAR_OID_PREFETCH
roshan0708
pushed a commit
to amazon-aurora/postgresql_modified_for_babelfish
that referenced
this pull request
Oct 18, 2024
…lfish-for-postgresql#295) Signed-off-by: Tim Chang <[email protected]> add full range of OID Remove ability to alter buffer size GUC, correct error messages Remove lc NULL check Remove references to TempVariableCache Revert "Remove lc NULL check" This reverts commit 07c28e5. Add proper check for toast tables Added comments, added OID macros Add temp table utilization warning Use correct backend for index_create workaround Add include Fix ALTER TABLE with TOAST issue Minor whitespace + comment Signed-off-by: Tim Chang <[email protected]> Ensure non-ENR temp works as expected Disable pgstat for temp tables to avoid concurrency issues Signed-off-by: Tim Chang <[email protected]> Moved new OID generation functions into extension hooks Signed-off-by: Tim Chang <[email protected]> Minor style fixes Signed-off-by: Tim Chang <[email protected]> Additional style fixed, removed obsolete vars Signed-off-by: Tim Chang <[email protected]> Remove 80% warning since it is misleading Signed-off-by: Tim Chang <[email protected]> Minor fixes Signed-off-by: Tim Chang <[email protected]> Move macro to transam for visibility Revert "Move macro to transam for visibility" This reverts commit ea15243. Add simple fetch for VAR_OID_PREFETCH
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change adds a separate OID buffer for temp objects. Since temp objects are already session-local, we can allocate a separate buffer of OIDs set aside only for temp objects. This same buffer range can be used across all sessions.
Check List
By submitting this pull request, I confirm that my contribution is under the terms of the PostgreSQL license, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.