Fix the incorrect string limit when declaring NVARCHAR(Max) #482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chenxiao Wang <[email protected]>
chxwang
force-pushed
the
jira-babel-5054
branch
from
105e5eb to
f0f04dc
Compare
Deepesh125
reviewed
Dec 16, 2024
| @@ -573,7 +573,7 @@ tsql_openjson_with_columnize(Jsonb *jb, char *col_info) | |||
| if (token) | |||
| { | |||
| token = strtok(NULL, ")"); | |||
| if (token) | |||
| if (token && atoi(token) > 0) | |||
There was a problem hiding this comment.
what was it returning for max?
There was a problem hiding this comment.
For nvarchar(max), token is -8000, here col_size was set as -8000
Adding this condition will make col_size the default size INT_MAX
shalinilohia50
approved these changes
Dec 16, 2024
Deepesh125
approved these changes
Dec 17, 2024
Deepesh125
merged commit a0aba15
into
babelfish-for-postgresql:BABEL_4_X_DEV__PG_16_X
2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously, the limit on the max length of NVARCHAR(Max) was 4000, longer characters will be truncated. But NVARCHAR(MAX) should be capable of handling strings far longer than 4,000 characters. This pr change the col_size to default INT_MAX.
Issues Resolved
BABEL-5054
Check List
By submitting this pull request, I confirm that my contribution is under the terms of the PostgreSQL license, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.