Automatic Solver Selection #26
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixed definingSolver not being set with multiple solvers for a constraint
add solver selection metrics about variable changes
the referenced lines have been restored in the other branch [skip ci]
Parse filter
so that code path is tested too
but did not receive it from reevaluateSolverSelection
call Constraint#abandon() instead of marking them and compacting the external variables also remove the abandoned Constraint from ConstrainedVariable._constraints, that did not happen before
Feature/32 refactoring
so you do not need to get the result of always that might not be possible in babelsberg-script anyway
This reverts commit 5970d64.
This reverts commit eb0dc87. Conflicts: standalone/webworker.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solvers are automatically selected if no solver is specified when a Constraint is created.
By default, the solving time matters most, but this can be changed to minimize the number of changed variables or the squared change distance for numeric values.
Several logging flags can be activated in the options. They will cause logging messages about the solver selection process to be emitted to the JavaScript console.