Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: cosmwasm consumer queries #381

Merged
merged 57 commits into from
Jun 20, 2024
Merged

feat: cosmwasm consumer queries #381

merged 57 commits into from
Jun 20, 2024

Conversation

gusin13
Copy link
Collaborator

@gusin13 gusin13 commented Jun 18, 2024 •
edited
Loading

This pr

  • implements cosmwasm consumer query interfaces
  • restructures files and functions

Note

  • the fp daemon will still not work until bcd is integrated in tests, i will work on this in next pr.
  • the query related to pub randomness is not implemented on contract side, i will open a pr there and then integrate that here in next pr.

@gusin13
Copy link
Collaborator Author

gusin13 commented Jun 19, 2024

thanks for the review guys, i have made the suggested changes. Please have another look

lesterli
lesterli reviewed Jun 19, 2024
View reviewed changes
clientcontroller/cosmwasm/consumer.go Outdated Show resolved Hide resolved
clientcontroller/cosmwasm/consumer.go Outdated Show resolved Hide resolved
clientcontroller/cosmwasm/consumer.go Outdated Show resolved Hide resolved
clientcontroller/cosmwasm/consumer.go Outdated Show resolved Hide resolved
clientcontroller/cosmwasm/msg.go Show resolved Hide resolved
SebastianElvis
SebastianElvis approved these changes Jun 20, 2024
View reviewed changes
Copy link
Member

@SebastianElvis SebastianElvis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

clientcontroller/cosmwasm/consumer.go Outdated Show resolved Hide resolved
finality-provider/config/cosmwasm.go Outdated Show resolved Hide resolved
itest/test_helpers.go Outdated Show resolved Hide resolved
itest/consumer_e2e_test.go Show resolved Hide resolved
maurolacy
maurolacy approved these changes Jun 20, 2024
View reviewed changes
Copy link
Contributor

@maurolacy maurolacy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@gusin13 gusin13 mentioned this pull request Jun 20, 2024
Closed
@gusin13 gusin13 merged commit 6d7b6ba into base/consumer-chain-support Jun 20, 2024
1 of 3 checks passed
@gusin13 gusin13 deleted the gusin13/fix-fp-app branch June 20, 2024 16:56
maurolacy pushed a commit that referenced this pull request Jul 5, 2024
@gusin13 @maurolacy
feat: cosmwasm consumer queries (#381)
0e5b112
gusin13 added a commit that referenced this pull request Jul 9, 2024
@gusin13
feat: cosmwasm consumer queries (#381)
95887fb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maurolacy maurolacy maurolacy approved these changes

@SebastianElvis SebastianElvis SebastianElvis approved these changes

@lesterli lesterli lesterli left review comments

@gitferry gitferry Awaiting requested review from gitferry

@bap2pecs bap2pecs Awaiting requested review from bap2pecs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gusin13 @lesterli @SebastianElvis @maurolacy