-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Rebase base onto dev #501
Draft
gusin13
wants to merge
71
commits into
dev
Choose a base branch
from
gusin13/base-to-dev
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Init * Update babylon-private reference * Revert "CI: Remove redundant SSH key logic (#218)"
* Add create and check FPs by chain support * Add consumer FP registration check * go lint * Improve error handling * Make chainID string * Adjust comment
…inalizedBlock()` (#347)
When error occurs, `block` is `nil` and `block.Height` will cause a nil pointer panic. Uncovered in local deployment
…cessed when e2e tests fails (#405)
This PR fixes a bug in CosmWasm consumer controller where we need to check whether the unmarshalled activated height is 0 or not. If it's 0 then it means we are unmarshalling something fishy and actually BTC staking is not activated, and we need to return an error, as [expected](https://github.com/babylonchain/finality-provider/blob/fee9b10e886a098ebd97b7ccfcf9e31bf465a746/finality-provider/service/chain_poller.go#L211-L220) by RPC poller. This fix allows us to remove some hacks and makes e2e / local deployment pass.
gusin13
changed the title
chore: Rebase base/consumer-chain-support branch onto dev
chore: Rebase base onto dev
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #480