Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Rebase base onto dev #501

Draft
wants to merge 71 commits into
base: dev
Choose a base branch
from
Draft

chore: Rebase base onto dev #501

wants to merge 71 commits into from

Conversation

gusin13
Copy link
Collaborator

@gusin13 gusin13 commented Jul 9, 2024

Fixes #480

maurolacy and others added 30 commits July 9, 2024 14:10
* Init
* Update babylon-private reference
* Revert "CI: Remove redundant SSH key logic (#218)"
* Add create and check FPs by chain support
* Add consumer FP registration check
* go lint
* Improve error handling
* Make chainID string
* Adjust comment
When error occurs, `block` is `nil` and `block.Height` will cause a nil
pointer panic. Uncovered in local deployment
bap2pecs and others added 29 commits July 9, 2024 15:02
This PR fixes a bug in CosmWasm consumer controller where we need to
check whether the unmarshalled activated height is 0 or not. If it's 0
then it means we are unmarshalling something fishy and actually BTC
staking is not activated, and we need to return an error, as
[expected](https://github.com/babylonchain/finality-provider/blob/fee9b10e886a098ebd97b7ccfcf9e31bf465a746/finality-provider/service/chain_poller.go#L211-L220)
by RPC poller. This fix allows us to remove some hacks and makes e2e /
local deployment pass.
@gusin13 gusin13 changed the title chore: Rebase base/consumer-chain-support branch onto dev chore: Rebase base onto dev Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rebasing base to dev
6 participants