add ordinals service metrics #219
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -114,13 +117,31 @@ func registerMetrics() { | |||
| []string{"baseurl", "method", "path", "status"}, | |||
| ) | |||
|
|
|||
| httpServiceErrorCounter = prometheus.NewCounterVec( | |||
There was a problem hiding this comment.
hmm... @jeremy-babylonchain i think u mis-understood my suggestion on the task.
We don't need a new metric emitter in the code as the existing clientRequestDurationHistogram has already covered the error and successful cases.
What we are missing is the alerts based on the clientRequestDurationHistogram metric based on its baseurl, path and status
You don't need code implementation in the staking api service, it shall live inside a repo from devops. fyi @hiepmai-babylonchain can probably help you on this
|
let's close this PR as i don't think we need it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#216