-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
F/optimizer ci #73
F/optimizer ci #73
Conversation
470724f
to
216d0d1
Compare
The only issue is that now the CI run goes from ~2 minutes to ~10 minutes :-/. Perhaps we remove the cosmwasm check and integration tests? And we can still run those when merging to |
The check is still necessary imo we need to ensure 1) wasm binaries can indeed be executed on CosmWasm env, and 2) the contract size is not bloated. I don't have better idea for optimising it though |
This last version is a good in-between solution IMO. We check that contract binaries compile, and we run the full checks only when merging to And, it runs in ~5 minutes, which is half the full run. |
I would say, let's go with this, and we can tune / adjust it later if needed / considered. |
Also, we should consider building our own optimiser docker image and push it to docker hub. So that we don't build it every time. Will create an issue for it. Update: #74. |
Good idea 👍 that shall slash the CI execution time a lot |
Enables optimiser run during PRs / on branches.