Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

F/optimizer ci #73

Merged
merged 3 commits into from
Sep 27, 2024
Merged

F/optimizer ci #73

merged 3 commits into from
Sep 27, 2024

Conversation

maurolacy
Copy link
Collaborator

Enables optimiser run during PRs / on branches.

@maurolacy
Copy link
Collaborator Author

maurolacy commented Sep 27, 2024

The only issue is that now the CI run goes from ~2 minutes to ~10 minutes :-/.

Perhaps we remove the cosmwasm check and integration tests? And we can still run those when merging to main. WDYT?

@SebastianElvis
Copy link
Member

The check is still necessary imo we need to ensure 1) wasm binaries can indeed be executed on CosmWasm env, and 2) the contract size is not bloated. I don't have better idea for optimising it though

@maurolacy
Copy link
Collaborator Author

maurolacy commented Sep 27, 2024

This last version is a good in-between solution IMO. We check that contract binaries compile, and we run the full checks only when merging to main / on release tags.

And, it runs in ~5 minutes, which is half the full run.

@maurolacy
Copy link
Collaborator Author

maurolacy commented Sep 27, 2024

I would say, let's go with this, and we can tune / adjust it later if needed / considered.

@maurolacy maurolacy merged commit 805ed4e into main Sep 27, 2024
3 checks passed
@maurolacy maurolacy deleted the f/optimizer-ci branch September 27, 2024 07:45
@maurolacy
Copy link
Collaborator Author

maurolacy commented Sep 27, 2024

Also, we should consider building our own optimiser docker image and push it to docker hub. So that we don't build it every time. Will create an issue for it.

Update: #74.

@SebastianElvis
Copy link
Member

So that we don't build it every time. Will create an issue for it.

Good idea 👍 that shall slash the CI execution time a lot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants