-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: finality gadget server #13
Conversation
This reverts commit 033ba5a.
6fe90ea
to
cfad1d3
Compare
ca91f3c
to
c288422
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a lot. Great work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for latest round of comments @SebastianElvis @bap2pecs, have addressed these |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary
This PR implements the finality gadget server, a stateful program used to track consecutive quorum and query the latest BTC-finalized block.
Integration tests are seperately added in the
finality-provider
repo (see below)Test plan
To run tests:
To run the finality gadget daemon:
Note that running the daemon with the default configs will throw a
block %d be finalized according to client but is not
error, because there aren't any FPs signing blocks, i.e. blocks are not registered as finalized. For testing purposes, we can overridequeryIsBlockBabylonFinalized
infinalitygadget.go
to returntrue, nil
for now.one the daemon is running, we can use Postman to test gRPC (need to import the
finalitygadget.proto
file) withlocalhost:8080
as the URL:then you can invoke queries like: