[announcements] Migrate announcements plugin #1134

kurtaking · 2024-08-30T15:00:16Z

Hey, I just made a Pull Request!

✔️ Checklist

A changeset describing the change and affected packages. (more info)
Added or updated documentation
Tests for new functionality and regression tests for bug fixes
Screenshots attached (for UI changes)
All your commits have a Signed-off-by line in the message. (more info)

Signed-off-by: Kurt King <[email protected]>

backstage-goalie · 2024-08-30T15:00:42Z

Missing Changesets

The following package(s) are changed by this PR but do not have a changeset:

@backstage-community/backstage-plugin-announcements-backend
@backstage-community/backstage-plugin-announcements-common
@backstage-community/backstage-plugin-announcements-node
@backstage-community/backstage-plugin-announcements-react
@backstage-community/backstage-plugin-announcements
@backstage-community/backstage-plugin-search-backend-module-announcements

See CONTRIBUTING.md for more information about how to add changesets.

Unexpected Changesets

The following changeset(s) reference packages that have not been changed in this PR:

/home/runner/work/community-plugins/community-plugins/workspaces/announcements/.changeset/twenty-bottles-care.md: @backstage-community/plugin-search-backend-module-announcements, @backstage-community/plugin-announcements-backend, @backstage-community/plugin-announcements-common, @backstage-community/plugin-announcements-react, @backstage-community/plugin-announcements-node, @backstage-community/announcements

Note that only changes that affect the published package require changesets, for example changes to tests and storybook stories do not require changesets.

Changed Packages

Package Name	Package Path	Changeset Bump	Current Version
@backstage-community/backstage-plugin-announcements-backend	workspaces/announcements/plugins/announcements-backend	none	`v0.10.4`
@backstage-community/backstage-plugin-announcements-common	workspaces/announcements/plugins/announcements-common	none	`v0.2.8`
@backstage-community/backstage-plugin-announcements-node	workspaces/announcements/plugins/announcements-node	none	`v0.3.3`
@backstage-community/backstage-plugin-announcements-react	workspaces/announcements/plugins/announcements-react	none	`v0.4.7`
@backstage-community/backstage-plugin-announcements	workspaces/announcements/plugins/announcements	none	`v0.11.2`
@backstage-community/backstage-plugin-search-backend-module-announcements	workspaces/announcements/plugins/search-backend-module-announcements	none	`v0.3.3`

Signed-off-by: Kurt King <[email protected]>

kurtaking · 2024-08-30T15:24:35Z

workspaces/announcements/package.json

+  "scripts": {
+    "dev": "concurrently \"yarn start\" \"yarn start-backend\"",
+    "start": "yarn workspace @backstage-community/plugin-announcements start",
+    "start-backend": "yarn workspace @backstage-community/plugin-announcements-backend start",
+    "start:ci": "concurrently \"yarn start\" \"yarn start-backend:ci\"",
+    "build": "backstage-cli repo build --all",
+    "tsc": "tsc",
+    "tsc:full": "tsc --skipLibCheck false --incremental false",
+    "new": "backstage-cli new --scope internal",
+    "clean": "backstage-cli repo clean",
+    "test": "backstage-cli repo test",
+    "test:all": "backstage-cli repo test --coverage",
+    "lint": "backstage-cli repo lint --since origin/main",
+    "lint:all": "backstage-cli repo lint",
+    "version": "changeset version && yarn install && (git commit -am 'Update internal dependencies' || true)",
+    "release": "changeset publish",
+    "prepare": "husky install",
+    "postinstall": "husky install || true"


todo: do I need to rework these?

Remove release and prepare, please.

Signed-off-by: Kurt King <[email protected]>

kurtaking · 2024-08-30T15:28:43Z

I've thoroughly reviewed 53 files and skimmed another 30. It would be helpful to have an initial review.

BethGriggs · 2024-09-02T14:18:49Z

Closing and reopening for the CI issue (we're working on that in #875)

BethGriggs · 2024-09-03T11:14:05Z

CI seems to be failing with on the yarn install step 🤔 I also notice the root yarn.lock has been updated - is that intentional?

github-actions · 2024-09-28T12:06:33Z

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

github-actions · 2024-10-18T18:05:46Z

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

awanlin

Thanks for want to migrate this plugin here @kurtaking, this is a large undertaking.

I've tried to review this mostly from a house keeping perspective. There's a lot of deprecated code being used and some patterns that could be improved but it makes more send to get this big PR in and then follow up with PRs around specific items.

awanlin · 2024-10-19T00:03:11Z

workspaces/announcements/env.sample

Do we need this file?

workspaces/announcements/package.json

awanlin · 2024-10-19T00:05:17Z

workspaces/announcements/package.json

+  "scripts": {
+    "dev": "concurrently \"yarn start\" \"yarn start-backend\"",
+    "start": "yarn workspace @backstage-community/plugin-announcements start",
+    "start-backend": "yarn workspace @backstage-community/plugin-announcements-backend start",
+    "start:ci": "concurrently \"yarn start\" \"yarn start-backend:ci\"",
+    "build": "backstage-cli repo build --all",
+    "tsc": "tsc",
+    "tsc:full": "tsc --skipLibCheck false --incremental false",
+    "new": "backstage-cli new --scope internal",
+    "clean": "backstage-cli repo clean",
+    "test": "backstage-cli repo test",
+    "test:all": "backstage-cli repo test --coverage",
+    "lint": "backstage-cli repo lint --since origin/main",
+    "lint:all": "backstage-cli repo lint",
+    "version": "changeset version && yarn install && (git commit -am 'Update internal dependencies' || true)",
+    "release": "changeset publish",
+    "prepare": "husky install",
+    "postinstall": "husky install || true"


Remove release and prepare, please.

workspaces/announcements/package.json

awanlin · 2024-10-19T00:07:19Z

workspaces/announcements/plugins/announcements-backend/CHANGELOG.md

@@ -0,0 +1,256 @@
+# @backstage-community/plugin-announcements-backend


If we are going to keep the old changelogs then they should reflect the history. Looking at this you would think this plugin was alway part of the @backstage-community scope.

awanlin · 2024-10-19T00:19:02Z

workspaces/announcements/plugins/announcements-react/CHANGELOG.md

@@ -0,0 +1,80 @@
+# @backstage-community/plugin-announcements-react


These should properly reflect their history or be removed.

awanlin · 2024-10-19T00:21:22Z

workspaces/announcements/plugins/announcements/CHANGELOG.md

@@ -0,0 +1,342 @@
+# @backstage-community/plugin-announcements


These should properly reflect their history or be removed.

awanlin · 2024-10-19T00:31:27Z

yarn.lock

This file should not be delete, please revert this change 👍

awanlin · 2024-10-19T00:34:57Z

workspaces/announcements/plugins/search-backend-module-announcements/CHANGELOG.md

@@ -0,0 +1,66 @@
+# @backstage-community/plugin-search-backend-module-announcements


Last one, should reflect history or be removed

awanlin · 2024-10-19T00:38:45Z

workspaces/announcements/README.md

@@ -0,0 +1,35 @@
+# Announcements plugin for Backstage
+
+## Overview


Can we please add a note to this about the history of this plugin, looking for the ownership changes. If that is somewhere else please point that out, this is a big PR and I may have missed it 👍

Signed-off-by: Kurt King <[email protected]>

Co-authored-by: Andre Wanlin <[email protected]> Signed-off-by: Kurt King <[email protected]>

Signed-off-by: Kurt King <[email protected]>

…s into announcements

awanlin · 2024-10-19T23:30:56Z

Closing as new PR #1637 was created

Migrate announcements plugin

d9667e9

Signed-off-by: Kurt King <[email protected]>

rename procore-oss to @backstage-community

cfd2789

Signed-off-by: Kurt King <[email protected]>

kurtaking force-pushed the announcements branch from f6397c1 to cfd2789 Compare August 30, 2024 15:15

kurtaking added 2 commits August 30, 2024 09:18

changeset

f366709

Signed-off-by: Kurt King <[email protected]>

update search module name

50b1caf

Signed-off-by: Kurt King <[email protected]>

kurtaking commented Aug 30, 2024

View reviewed changes

cleanup outdated info

483c961

Signed-off-by: Kurt King <[email protected]>

kurtaking marked this pull request as ready for review August 30, 2024 15:27

kurtaking requested review from backstage-service and a team as code owners August 30, 2024 15:27

kurtaking requested a review from BethGriggs August 30, 2024 15:27

kurtaking mentioned this pull request Aug 30, 2024

[ON HOLD]: Migrating announcements plugins to @backstage-community/plugins repository procore-oss/backstage-plugin-announcements#373

Open

kurtaking changed the title ~~Migrate announcements plugin~~ [announcements] Migrate announcements plugin Aug 30, 2024

BethGriggs closed this Sep 2, 2024

BethGriggs reopened this Sep 2, 2024

github-actions bot added the stale label Sep 28, 2024

BethGriggs removed the stale label Oct 2, 2024

Merge branch 'main' into announcements

469f33d

github-actions bot added the stale label Oct 18, 2024

Merge branch 'main' into announcements

3cf5bb7

awanlin requested review from awanlin and removed request for BethGriggs October 18, 2024 20:10

github-actions bot removed the stale label Oct 19, 2024

awanlin requested changes Oct 19, 2024

View reviewed changes

kurtaking and others added 5 commits October 18, 2024 19:35

Merge branch 'backstage:main' into announcements

e0d48e9

move latest code

2cc484d

Signed-off-by: Kurt King <[email protected]>

Apply suggestions from code review

a1753db

Co-authored-by: Andre Wanlin <[email protected]> Signed-off-by: Kurt King <[email protected]>

remove unused files

cffa1ec

Signed-off-by: Kurt King <[email protected]>

Merge branch 'announcements' of github.com:kurtaking/community-plugin…

2fb1ce2

…s into announcements

awanlin closed this Oct 19, 2024

kurtaking deleted the announcements branch October 20, 2024 18:50

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[announcements] Migrate announcements plugin #1134

[announcements] Migrate announcements plugin #1134

kurtaking commented Aug 30, 2024 •

edited

Loading

backstage-goalie bot commented Aug 30, 2024 •

edited

Loading

kurtaking Aug 30, 2024

awanlin Oct 19, 2024

kurtaking commented Aug 30, 2024

BethGriggs commented Sep 2, 2024

BethGriggs commented Sep 3, 2024

github-actions bot commented Sep 28, 2024

github-actions bot commented Oct 18, 2024

awanlin left a comment

awanlin Oct 19, 2024

awanlin Oct 19, 2024

awanlin Oct 19, 2024

awanlin Oct 19, 2024

awanlin Oct 19, 2024

awanlin Oct 19, 2024

awanlin Oct 19, 2024

awanlin Oct 19, 2024

awanlin commented Oct 19, 2024

		@@ -0,0 +1,256 @@
		# @backstage-community/plugin-announcements-backend

		@@ -0,0 +1,80 @@
		# @backstage-community/plugin-announcements-react

		@@ -0,0 +1,342 @@
		# @backstage-community/plugin-announcements

		@@ -0,0 +1,66 @@
		# @backstage-community/plugin-search-backend-module-announcements

		@@ -0,0 +1,35 @@
		# Announcements plugin for Backstage

		## Overview

[announcements] Migrate announcements plugin #1134

[announcements] Migrate announcements plugin #1134

Conversation

kurtaking commented Aug 30, 2024 • edited Loading

Hey, I just made a Pull Request!

✔️ Checklist

backstage-goalie bot commented Aug 30, 2024 • edited Loading

Missing Changesets

Unexpected Changesets

Changed Packages

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kurtaking commented Aug 30, 2024

BethGriggs commented Sep 2, 2024

BethGriggs commented Sep 3, 2024

github-actions bot commented Sep 28, 2024

github-actions bot commented Oct 18, 2024

awanlin left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

awanlin commented Oct 19, 2024

kurtaking commented Aug 30, 2024 •

edited

Loading

backstage-goalie bot commented Aug 30, 2024 •

edited

Loading