ci(release_workspace): add additional checks and document workflow #1175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BethGriggs
force-pushed
the
poc-multiple-releases-pt-2
branch
3 times, most recently
from
19e754b
to
9108c14
Compare
- Introduced logic to verify the branch name is valid for the workspace - Added handling for missing GitHub events in release checks - Introduced logic to set npm publish tag (latest or maintenance) - Added initial plugin maintainer guide for patching older release lines Signed-off-by: Beth Griggs <[email protected]>
BethGriggs
force-pushed
the
poc-multiple-releases-pt-2
branch
from
9108c14
to
dc772bd
Compare
BethGriggs
changed the title
awanlin
requested changes
Sep 8, 2024
There was a problem hiding this comment.
Thanks for running with this @BethGriggs, also for including docs, left two comments.
I don't know the release flow well, @benjdlambert any chance you can look at this one, please?
|
|
||
| When patching an older release, follow the steps below to ensure the correct workflow is applied: | ||
|
|
||
| 1. Request a `workspace/${workspace}` branch: |
There was a problem hiding this comment.
How does one request a branch?
| - Apply the necessary patch fixes or security updates. | ||
| - Manually bump the version in `package.json` to reflect the new patch version (e.g., from `1.2.3` to `1.2.4`). | ||
|
|
||
| 4. Run the release workflow: |
There was a problem hiding this comment.
Should we highlight what access you need to be able to run the workflow? This could go in a section towards the top. Pretty sure you need to be an Org Member 🤔
|
During the SIG today we discussed some various improvements and further prototyping needed here, I'll work on those |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
workspace/${workspace}branchinput from the workflowHey, I just made a Pull Request!
✔️ Checklist
Signed-off-byline in the message. (more info)