Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(3scale)!: migrate to the new backend and remove deprecations #1254

Merged
merged 24 commits into from
Sep 25, 2024
Merged

feat(3scale)!: migrate to the new backend and remove deprecations #1254

merged 24 commits into from
Sep 25, 2024

Conversation

04kash
Copy link
Contributor

@04kash 04kash commented Sep 18, 2024 •
edited
Loading

Hey, I just made a Pull Request!

  • removes legacy backend system
  • removes deprecations

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)
  • All your commits have a Signed-off-by line in the message. (more info)

@backstage-goalie
Copy link
Contributor

backstage-goalie bot commented Sep 18, 2024 •
edited
Loading

Changed Packages

Package Name Package Path Changeset Bump Current Version
@backstage-community/plugin-3scale-backend workspaces/3scale/plugins/3scale-backend major v1.8.5

@04kash 04kash marked this pull request as ready for review September 19, 2024 15:19
@04kash 04kash requested a review from a team as a code owner September 19, 2024 15:19
@04kash 04kash changed the title feat(3scale): migrate to the new backend and remove deprecations feat(3scale)!: migrate to the new backend and remove deprecations Sep 19, 2024
@04kash 04kash mentioned this pull request Sep 24, 2024
Closed
1 task
@backstage-goalie
Copy link
Contributor

Thanks for the contribution!
All commits need to be DCO signed before they are reviewed. Please refer to the the DCO section in CONTRIBUTING.md or the DCO status for more info.

@04kash 04kash force-pushed the 3scale-migration branch 2 times, most recently from 7cec455 to da1422a Compare September 24, 2024 20:41
@timbonicus timbonicus removed the request for review from a team September 25, 2024 06:54
schultzp2020
schultzp2020 approved these changes Sep 25, 2024
View reviewed changes
Copy link
Contributor

@schultzp2020 schultzp2020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@04kash
Copy link
Contributor Author

04kash commented Sep 25, 2024

@BethGriggs could you take a look and approve?

04kash and others added 21 commits September 25, 2024 23:06
@04kash @BethGriggs
Remove legacy backend references in README.md
49c318c 
Signed-off-by: Kashish Mittal <[email protected]>
@04kash @BethGriggs
update src/alpha.ts
51708b7 
Signed-off-by: Kashish Mittal <[email protected]>
@04kash @BethGriggs
feat(3scale): migrate to the new backend and remove deprecations
21e8c60 
Signed-off-by: Kashish Mittal <[email protected]>
@04kash @BethGriggs
add changeset
1256158 
Signed-off-by: Kashish Mittal <[email protected]>
@04kash @BethGriggs
update dev/index.ts
c41cb2a 
Signed-off-by: Kashish Mittal <[email protected]>
@04kash @BethGriggs
update api reports
c2670e7 
Signed-off-by: Kashish Mittal <[email protected]>
@04kash @BethGriggs
dedupe yarn.lock
0af2fbc 
Signed-off-by: Kashish Mittal <[email protected]>
@04kash @BethGriggs
add dist-dynamic
95e018c 
Signed-off-by: Kashish Mittal <[email protected]>
@04kash @BethGriggs
update package.json
ff24e7e 
Signed-off-by: Kashish Mittal <[email protected]>
@04kash @BethGriggs
Update eighty-suits-sell.md
1afaec0 
Signed-off-by: Kashish Mittal <[email protected]>
@04kash @BethGriggs
add type modifier to imports
478ae96 
Signed-off-by: Kashish Mittal <[email protected]>
@04kash @BethGriggs
package.json updates
fa56015 
Signed-off-by: Kashish Mittal <[email protected]>
@04kash @BethGriggs
update dist-dynamic
db4c805 
Signed-off-by: Kashish Mittal <[email protected]>
@04kash @BethGriggs
yarn dedupe
e931571 
Signed-off-by: Kashish Mittal <[email protected]>
@04kash @BethGriggs
fix ci failures
4f1f035 
Signed-off-by: Kashish Mittal <[email protected]>
@04kash @dzemanov @BethGriggs
Update workspaces/3scale/plugins/3scale-backend/src/providers/ThreeSc…
5576038 
…aleApiEntityProvider.ts

Co-authored-by: Dominika Zemanovicova <[email protected]>
Signed-off-by: Kashish Mittal <[email protected]>
@04kash @BethGriggs
update api reports
6b12b9a 
Signed-off-by: Kashish Mittal <[email protected]>
@04kash @BethGriggs
update api reports
94ef4f5 
Signed-off-by: Kashish Mittal <[email protected]>
@04kash @schultzp2020 @BethGriggs
Update workspaces/3scale/plugins/3scale-backend/tsconfig.json
bb0f594 
Co-authored-by: Paul Schultz <[email protected]>
Signed-off-by: Kashish Mittal <[email protected]>
@04kash @schultzp2020 @BethGriggs
Update workspaces/3scale/plugins/3scale-backend/dist-dynamic/README.md
af202cc 
Co-authored-by: Paul Schultz <[email protected]>
Signed-off-by: Kashish Mittal <[email protected]>
@04kash @BethGriggs
update README.md
52efc44 
Signed-off-by: Kashish Mittal <[email protected]>
@BethGriggs BethGriggs merged commit 577034b into backstage:main Sep 25, 2024
12 checks passed
karthikjeeyar pushed a commit to karthikjeeyar/community-plugins that referenced this pull request Oct 28, 2024
@04kash @dzemanov
@schultzp2020 @karthikjeeyar
plugin(3scale): migrate to the new backend and remove deprecations (b…
87b7344 
…ackstage#1254)

* remove run.ts
* update dev/index.ts to use the new backend system
* remove the legacy dynamic plugin installer
* remove legacy backend references in README.md
* update src/alpha.ts
* migrate to the new backend and remove deprecations
* add changeset
* update dev/index.ts
* update api reports
* dedupe yarn.lock
* add dist-dynamic
* update package.json
* update eighty-suits-sell.md
* add type modifier to imports
* package.json updates
* update dist-dynamic
* yarn dedupe
* fix ci failures
* update workspaces/3scale/plugins/3scale-backend/src/providers/ThreeScaleApiEntityProvider.ts
* update api reports

Signed-off-by: Kashish Mittal <[email protected]>
Signed-off-by: Kashish Mittal <[email protected]>
Co-authored-by: Dominika Zemanovicova <[email protected]>
Co-authored-by: Paul Schultz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dzemanov dzemanov dzemanov left review comments

@schultzp2020 schultzp2020 schultzp2020 approved these changes

@BethGriggs BethGriggs BethGriggs approved these changes

@Xantier Xantier Awaiting requested review from Xantier

@andrewthauer andrewthauer Awaiting requested review from andrewthauer

@yashoswalyo yashoswalyo Awaiting requested review from yashoswalyo

@kuangp kuangp Awaiting requested review from kuangp

@jmezach jmezach Awaiting requested review from jmezach

@awanlin awanlin Awaiting requested review from awanlin

@gregorytalita gregorytalita Awaiting requested review from gregorytalita

@erikengervall erikengervall Awaiting requested review from erikengervall

@alde alde Awaiting requested review from alde

@backstage-service backstage-service Awaiting requested review from backstage-service

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@04kash @BethGriggs @dzemanov @schultzp2020