-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
copilot: Introduced support for organizations and team metrics visualization #1261
base: main
Are you sure you want to change the base?
Conversation
Changed Packages
|
Thanks for the contribution! |
5ad97d5
to
b5f542e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some initial thoughts from trying this plugin out in our instance.
The styling looks good, however, it needs to respect the global theme provider so that it better fits in with the styling of the instance.
workspaces/copilot/plugins/copilot/src/components/Pages/Page.tsx
Outdated
Show resolved
Hide resolved
import { styled } from '@mui/material/styles'; | ||
import { Metric } from '@backstage-community/plugin-copilot-common'; | ||
|
||
const CardBox = styled(Box)(() => ({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There seems to be something about this way of styling components that seems to "leak" out from this plugin and affect unrelated components in the rest of the instance that it is installed into.
Im not an expert in this so I can't say what it is. @awanlin can you shed some light on this?
Hi @esw-afabiano, would it be possible to break this up? Ideally one PR focused on the initial feature and then another for the theme and style changes? There also seems to be GitHub integration/token changes. These large PRs are hard to review and lead to what you are experiencing where you are having to do follow up work based on Adopter feedback. Also, can you post a screenshot of the images in use? Are they really needed? They don't really fit into the look and feel of Backstage and images are not really used like this anywhere. I realize I'm being the "no fun police" but a lot of Orgs are going to be frustrated by this as they have specific brand standards they follow. Maybe this is opt in? |
I can certainly break this up, but I'll need to wait for this PR to be merged first. There have been significant changes to the project, and the style updates are based on the new layout. If you’d like me to separate them, I can do that! Regarding the image, I felt that there wasn't much creativity in designing that screen, so I decided to include an image. I've also added a GIF that shows its usage: demo.gif. Let me know if you need any adjustments! |
Needs rebase and maybe to split into smaller PRs? |
2c47b01
to
61eb8c1
Compare
@awanlin, regarding the issue raised about the image, does it make sense as it is now, or do we need to change it? As for splitting this into two PRs, one for the feature and another for the theme fix, as I mentioned earlier, it can be done. However, the structure has been significantly altered. This also ties into the point raised by @nickboldt about breaking it into smaller PRs. The complicating factor is that one part depends on the other, and splitting it into smaller PRs would likely break the application. We already have a functional version of this, so I'm not sure if it's the right approach for this PR. I'm willing to do whatever is necessary, but I also want to avoid creating additional problems and rework. Looking forward to the next steps and seeing this version used by the community! |
workspaces/copilot/plugins/copilot-backend/src/service/validation/schema.ts
Outdated
Show resolved
Hide resolved
workspaces/copilot/plugins/copilot-backend/src/service/router.ts
Outdated
Show resolved
Hide resolved
workspaces/copilot/plugins/copilot-backend/src/service/router.ts
Outdated
Show resolved
Hide resolved
workspaces/copilot/plugins/copilot-backend/src/service/router.ts
Outdated
Show resolved
Hide resolved
workspaces/copilot/plugins/copilot-backend/src/service/router.ts
Outdated
Show resolved
Hide resolved
workspaces/copilot/plugins/copilot-backend/src/processors/OrganizationTeamProcessor.ts
Outdated
Show resolved
Hide resolved
workspaces/copilot/plugins/copilot-backend/src/processors/ProcessorManagement.ts
Outdated
Show resolved
Hide resolved
8df0d1c
to
4ea6947
Compare
workspaces/copilot/plugins/copilot-backend/migrations/202410191705_add_new_columns.js
Show resolved
Hide resolved
dd44258
to
ab07dc4
Compare
did not work! |
I still see some changes to the |
Signed-off-by: Alisson Fabiano <[email protected]>
Signed-off-by: Alisson Fabiano <[email protected]>
Signed-off-by: Alisson Fabiano <[email protected]>
ab07dc4
to
dcdfd03
Compare
Signed-off-by: Alisson Fabiano <[email protected]>
@vinzscam Well.. the resolution was to have to uninstall my yarn package and reinstall using npm in version 1.22.19, and then it was able to get the yarn version defined in the project. It seems to be 100% now |
Hey @vinzscam, any chance to merge this? |
Signed-off-by: Alisson Fabiano <[email protected]>
It would be great to have it released 🙏🏻 |
Hey, I just made a Pull Request!
This update introduces support for both organizations and team metrics visualization in the GitHub Copilot plugin. With these new features, users can now select specific teams within their organization and compare their metrics with overall data, providing more insightful analysis and management capabilities.
Additionally 1: the images included in this update, which showcase various visual aspects of the plugin, were generated using the GPT AI model. To the best of our knowledge, these images are free to use, as they were created by the AI without any existing copyright restrictions.
Additionally 2: this PR also fixes the styles within the GitHub Copilot plugin to ensure that they work seamlessly with the Backstage theme system. The components should now behave consistently, adapting to the current theme (light or dark) without issues, aligning with the other components in Backstage.
✔️ Checklist
Signed-off-by
line in the message. (more info)