Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix create-workspace templates #1262

Merged
merged 6 commits into from
Sep 20, 2024
Merged

Conversation

04kash
Copy link
Contributor

@04kash 04kash commented Sep 19, 2024

Hey, I just made a Pull Request!

Fix formatting of catalog-info.yaml, package.json and .gitignore.
Fixes: #1218

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)
  • All your commits have a Signed-off-by line in the message. (more info)

Signed-off-by: Kashish Mittal <[email protected]>
@04kash 04kash requested a review from a team as a code owner September 19, 2024 19:04
@backstage-goalie
Copy link
Contributor

backstage-goalie bot commented Sep 19, 2024

Changed Packages

Package Name Package Path Changeset Bump Current Version
@backstage-community/cli workspaces/repo-tools/packages/cli none v0.0.3

04kash and others added 5 commits September 19, 2024 15:10
Signed-off-by: Kashish Mittal <[email protected]>
Signed-off-by: Kashish Mittal <[email protected]>
Signed-off-by: Kashish Mittal <[email protected]>
Signed-off-by: Kashish Mittal <[email protected]>
Copy link
Member

@vinzscam vinzscam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! I've removed the changeset since it isn't necessary for private packages :shipit:

@vinzscam vinzscam merged commit 7c68b00 into backstage:main Sep 20, 2024
11 checks passed
04kash added a commit to 04kash/community-plugins that referenced this pull request Sep 24, 2024
* fix create-workspace templates

Signed-off-by: Kashish Mittal <[email protected]>

* add changeset

Signed-off-by: Kashish Mittal <[email protected]>

* Update catalog-info.yaml.hbs

Signed-off-by: Kashish Mittal <[email protected]>

* Update .gitignore.hbs

Signed-off-by: Kashish Mittal <[email protected]>

* Update package.json.hbs

Signed-off-by: Kashish Mittal <[email protected]>

* Delete workspaces/repo-tools/.changeset/breezy-stingrays-try.md

Signed-off-by: Vincenzo Scamporlino <[email protected]>

---------

Signed-off-by: Kashish Mittal <[email protected]>
Signed-off-by: Kashish Mittal <[email protected]>
Signed-off-by: Vincenzo Scamporlino <[email protected]>
Co-authored-by: Vincenzo Scamporlino <[email protected]>
@04kash 04kash deleted the fix-create-workspace branch September 26, 2024 18:30
karthikjeeyar pushed a commit to karthikjeeyar/community-plugins that referenced this pull request Oct 28, 2024
* fix create-workspace templates

Signed-off-by: Kashish Mittal <[email protected]>

* add changeset

Signed-off-by: Kashish Mittal <[email protected]>

* Update catalog-info.yaml.hbs

Signed-off-by: Kashish Mittal <[email protected]>

* Update .gitignore.hbs

Signed-off-by: Kashish Mittal <[email protected]>

* Update package.json.hbs

Signed-off-by: Kashish Mittal <[email protected]>

* Delete workspaces/repo-tools/.changeset/breezy-stingrays-try.md

Signed-off-by: Vincenzo Scamporlino <[email protected]>

---------

Signed-off-by: Kashish Mittal <[email protected]>
Signed-off-by: Kashish Mittal <[email protected]>
Signed-off-by: Vincenzo Scamporlino <[email protected]>
Co-authored-by: Vincenzo Scamporlino <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🔧 Repository: create-workspace generates wrong templates
2 participants