-
Notifications
You must be signed in to change notification settings - Fork 268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add azureResources workspace and service #2510
base: main
Are you sure you want to change the base?
Conversation
Changed Packages
|
c4b07b1
to
e2eeda0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Sarabadu, thanks for this! Left some comments.
Also, the CI is currently failing due to type errors, could you take a look at that?
workspaces/azure-resources/plugins/azure-resources-node/package.json
Outdated
Show resolved
Hide resolved
workspaces/azure-resources/plugins/azure-resources-node/README.md
Outdated
Show resolved
Hide resolved
Thanks @04kash will look at this |
32e76fa
to
a4d4929
Compare
hey @04kash the types and comments should be fixed now, could you please trigger the CI and take another look? |
@04kash seems like my tooling was not correct on local, sry about that |
db29cee
to
7df6590
Compare
Signed-off-by: Juan Pablo Garcia Ripa <[email protected]> Co-authored-by: Fernanda Silva <[email protected]> Co-authored-by: Alejandro Quisbert <[email protected]> Co-authored-by: Alejandro Quisbert <[email protected]>
Signed-off-by: Juan Pablo Garcia Ripa <[email protected]>
Signed-off-by: Juan Pablo Garcia Ripa <[email protected]>
Signed-off-by: Juan Pablo Garcia Ripa <[email protected]>
7df6590
to
fa5eaaa
Compare
Hey, I just made a Pull Request!
This PR creates the azureResources workspace and one service node package.
The reasoning behind this PR is to provide a way to interact with Azure resources in Backstage. we have many plugins that use this api (some of them are internal and other we plan to contribute) and not having a shared service ref, end up duplicating configurations in many places.
✔️ Checklist
Signed-off-by
line in the message. (more info)