Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add azureResources workspace and service #2510

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Sarabadu
Copy link

@Sarabadu Sarabadu commented Jan 15, 2025

Hey, I just made a Pull Request!

This PR creates the azureResources workspace and one service node package.

The reasoning behind this PR is to provide a way to interact with Azure resources in Backstage. we have many plugins that use this api (some of them are internal and other we plan to contribute) and not having a shared service ref, end up duplicating configurations in many places.

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)
  • All your commits have a Signed-off-by line in the message. (more info)

@backstage-goalie
Copy link
Contributor

backstage-goalie bot commented Jan 15, 2025

Changed Packages

Package Name Package Path Changeset Bump Current Version
@backstage-community/plugin-azure-resources-node workspaces/azure-resources/plugins/azure-resources-node patch v0.1.0

@Sarabadu Sarabadu marked this pull request as ready for review January 17, 2025 22:14
@Sarabadu Sarabadu requested review from backstage-service and a team as code owners January 17, 2025 22:14
@Sarabadu Sarabadu requested a review from 04kash January 17, 2025 22:14
Copy link
Member

@04kash 04kash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Sarabadu, thanks for this! Left some comments.

Also, the CI is currently failing due to type errors, could you take a look at that?

@Sarabadu
Copy link
Author

Thanks @04kash will look at this

@Sarabadu
Copy link
Author

hey @04kash the types and comments should be fixed now, could you please trigger the CI and take another look?

@Sarabadu
Copy link
Author

@04kash seems like my tooling was not correct on local, sry about that
i checked now most of the commands on CI locally

Sarabadu and others added 4 commits January 22, 2025 15:02
Signed-off-by: Juan Pablo Garcia Ripa <[email protected]>
Co-authored-by: Fernanda Silva <[email protected]>
Co-authored-by: Alejandro Quisbert <[email protected]>
Co-authored-by: Alejandro Quisbert <[email protected]>
Signed-off-by: Juan Pablo Garcia Ripa <[email protected]>
Signed-off-by: Juan Pablo Garcia Ripa <[email protected]>
Signed-off-by: Juan Pablo Garcia Ripa <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants