Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue template workspace dropdown #2537

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

kurtaking
Copy link
Member

@kurtaking kurtaking commented Jan 16, 2025

Hey, I just made a Pull Request!

A start at solving for #2507.

I identified issue templates don't allow for importing from other yaml files. So, we would need to keep the dropdown up-to-date in each template.

  • refactor functionality to list workspaces to dedicated helper function list-workspaces.js
  • refactor existing scripts to use listWorkspaces()
  • add create-workspaces-dropdown.js to generate the yaml dropdown

Testing

  • ran each script locally after refactor

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)
  • All your commits have a Signed-off-by line in the message. (more info)

@kurtaking kurtaking force-pushed the issue-template-workspace-dropdown branch from 08d7a06 to 5b61ecc Compare January 16, 2025 15:35
@kurtaking kurtaking force-pushed the issue-template-workspace-dropdown branch from c097164 to a775e49 Compare January 16, 2025 15:38
Signed-off-by: Kurt King <[email protected]>
@kurtaking kurtaking marked this pull request as ready for review January 16, 2025 15:41
@kurtaking kurtaking requested a review from a team as a code owner January 16, 2025 15:41
@kurtaking kurtaking requested a review from 04kash January 16, 2025 15:41
@kurtaking
Copy link
Member Author

Soliciting feedback on whether or not it would be worth maintaining the dropdown list manually. Perhaps, trying to add a label based on the user's input in the issue, even if it occasionally doesn't work due to typos, may outweigh maintaining the dropdown list in each issue.

@04kash
Copy link
Member

04kash commented Jan 16, 2025

Could we have another script to rewrite the whole ISSUE_TEMPLATE (I think the only ones where we'd want to use the drop down are: 1-bug.yaml and 2-feature.yaml) with the updated workspaces? We could have a cron job to run this script periodically.

@kurtaking
Copy link
Member Author

Could we have another script to rewrite the whole ISSUE_TEMPLATE (I think the only ones where we'd want to use the drop down are: 1-bug.yaml and 2-feature.yaml) with the updated workspaces? We could have a cron job to run this script periodically.

I like the idea, and it's doable. I'll work on it more and then ping you.

@kurtaking kurtaking force-pushed the issue-template-workspace-dropdown branch from 3b94a2a to ba0126f Compare January 22, 2025 03:48
@kurtaking kurtaking force-pushed the issue-template-workspace-dropdown branch from ba0126f to fde1518 Compare January 22, 2025 03:54
Signed-off-by: Kurt King <[email protected]>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

todo:

  • what is the best way to test this action?
  • should probably improve the output logging

@kurtaking
Copy link
Member Author

Hey @04kash - made some progress here and could use a review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants