Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate @material-ui to @mui and enable the Backstage proxy to communicate with the OpenCost service #2550

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

and-arevalo
Copy link

@and-arevalo and-arevalo commented Jan 20, 2025

Hey, I just made a Pull Request!

This PR addresses the following issues:

  • Resolved OpenCost Plugin Breakage:

    • The OpenCost plugin was experiencing issues due to changes in its dependencies.
    • This PR includes necessary fixes to ensure the plugin functions correctly.
  • Migrated from @material-ui to @mui:

    • Upgraded to the latest MUI library for access to the latest features.
  • Enabled Backstage Proxy for OpenCost Service Communication:

    • Configured the Backstage proxy to facilitate communication with the OpenCost service. This enables users to integrate Backstage with private Opencost installations.

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)
  • All your commits have a Signed-off-by line in the message. (more info)

@and-arevalo and-arevalo requested review from backstage-service and a team as code owners January 20, 2025 13:35
@and-arevalo and-arevalo requested a review from 04kash January 20, 2025 13:35
@backstage-goalie
Copy link
Contributor

Changed Packages

Package Name Package Path Changeset Bump Current Version
@backstage-community/plugin-opencost workspaces/opencost/plugins/opencost minor v0.3.0

…icate with the OpenCost service

Signed-off-by: and-arevalo <[email protected]>
Signed-off-by: and-arevalo <[email protected]>
@mattray
Copy link

mattray commented Jan 22, 2025

It looks OK to me, but I'm not able to test it right now. If someone could validate it works for them I'm happy to approve it.

I'm no longer involved with OpenCost, so I'm more than happy to hand off responsibility to someone else.

Copy link
Member

@vinzscam vinzscam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately migrating to material-ui v6 is not an option (see backstage/backstage#27726) 😞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants