fix(rbac): evaluate permissions for superuser sooner #2551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Patrick <[email protected]>
PatAKnight
requested review from
AndrienkoAleksandr,
christoph-jerolimov and
a team
as code owners
Changed Packages
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, I just made a Pull Request!
This PR aims to evaluate permission requests for a superuser earlier in the handle process. Before this PR, conditional policies would be applied to a superuser unintentionally due to the superuser being processed after conditional permission policies. In this PR, I have moved the check for superusers to the start of the evaluation process to fix this problem as well as speed up the results.
✔️ Checklist
Signed-off-byline in the message. (more info)