Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added gitIgnoredAuthors to Renovate #911

Merged
merged 5 commits into from
Nov 6, 2024

Conversation

awanlin
Copy link
Contributor

@awanlin awanlin commented Aug 23, 2024

Hey, I just made a Pull Request!

Added gitIgnoredAuthors to the Renovate config based on a recommendation on Discord from @secustor.

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)
  • All your commits have a Signed-off-by line in the message. (more info)

@awanlin awanlin requested a review from a team as a code owner August 23, 2024 13:39
@awanlin awanlin requested a review from nickboldt August 23, 2024 13:39
@awanlin
Copy link
Contributor Author

awanlin commented Aug 23, 2024

Hi @secustor, sorry for the pings, when you have time can you give this a look, please?

@@ -32,5 +32,6 @@
"allowedVersions": "<5.0.0"
}
],
"ignorePaths": ["**/dist-dynamic/**"]
"ignorePaths": ["**/dist-dynamic/**"],
"gitIgnoredAuthors": ["backstage-goalie"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, alright, not sure how to figure that out but will dig into it. Thanks for taking the time to review this 👍

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@benjdlambert @freben could either of you help me with this? Having this in place would help with our Renovate process in this repo.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Rugvip do you know what the email of the backstage-goalie bot is/

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @awanlin, does this help?

community-plugins $ git shortlog --summary --numbered --email | grep goalie
    32  backstage-goalie[bot] <97962292+backstage-goalie[bot]@users.noreply.github.com>

@nickboldt nickboldt requested review from freben and benjdlambert and removed request for nickboldt September 24, 2024 15:37
Copy link
Contributor

github-actions bot commented Oct 9, 2024

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

@github-actions github-actions bot added the stale label Oct 9, 2024
@github-actions github-actions bot removed the stale label Oct 9, 2024
Copy link
Contributor

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

@github-actions github-actions bot added stale and removed stale labels Oct 23, 2024
.github/renovate.json Outdated Show resolved Hide resolved
@nickboldt nickboldt enabled auto-merge (squash) November 6, 2024 13:56
@nickboldt nickboldt merged commit 9d49990 into backstage:main Nov 6, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants