Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

todo - version:bump to v1.30.2 #953

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

backstage-service
Copy link
Collaborator

Backstage release v1.30.2 has been published, this Pull Request contains the changes to upgrade todo to this new release

Please review the changelog before approving, there may be manual changes needed:

Created by Version Bump 10531439027

@awanlin
Copy link
Contributor

awanlin commented Aug 24, 2024

Hi @Rugvip, when you have some time could use some help on why this one is failing the type check, please?

@Rugvip
Copy link
Member

Rugvip commented Aug 24, 2024

@awanlin hmm, something's up. I'll have a look next week but this is prolly a framework issue

@nickboldt nickboldt closed this Aug 27, 2024
@nickboldt nickboldt reopened this Aug 27, 2024
@awanlin
Copy link
Contributor

awanlin commented Sep 8, 2024

Hi @Rugvip, if you could give this another look that would be awesome! 🙏

Copy link
Member

@Rugvip Rugvip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@Rugvip
Copy link
Member

Rugvip commented Sep 9, 2024

Pushed a fix for the type issue, wasn't anything too serious. The explicit ServiceRef type without type parameters made the service ref type too open, fix was to remove the explicit type.

@backstage-goalie
Copy link
Contributor

Thanks for the contribution!
All commits need to be DCO signed before they are reviewed. Please refer to the the DCO section in CONTRIBUTING.md or the DCO status for more info.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants