Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(EW): /tips page #196

Merged
merged 11 commits into from
Jun 26, 2024
Merged

feat(EW): /tips page #196

merged 11 commits into from
Jun 26, 2024

Conversation

ltclmbdev
Copy link
Contributor

@ltclmbdev ltclmbdev commented Jun 21, 2024

This is the first iteration for the /tips and /tips/[slug] pages.

What was added:

/tips

  • styles

/tips/[slug]

  • styles
  • transcription (with timestamp buttons properly work)
  • dynamic og images
/tips
/tips/[slug]
og image

Missed functionalities:

  • implement resource completion functionality
  • extend tips data (in getTipsModule) with instructor data
  • MoreTips component

Water Instrument GIF by America's Funniest Home Videos

Copy link

vercel bot commented Jun 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
course-builder-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 25, 2024 9:22pm
course-builder-poc ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 25, 2024 9:22pm
course-builder-video-blog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 25, 2024 9:22pm
epic-web-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 25, 2024 9:22pm
pro-aws ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 25, 2024 9:22pm
pro-nextjs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 25, 2024 9:22pm
value-based-design ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 25, 2024 9:22pm

with: {
resources: {
with: {
resource: true,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added these lines to get muxPlaybackId in what getTipsModule returns

@ltclmbdev ltclmbdev added the WIP This PR is a work in progress, not intended to be merged yet. label Jun 24, 2024
@ltclmbdev ltclmbdev marked this pull request as draft June 24, 2024 18:16
// import { revalidateTutorialLesson } from '@/app/(content)/tutorials/actions'
import Spinner from '@/components/spinner'
// import { VideoBlockNewsletterCta } from '@/components/video-block-newsletter-cta'
// import { addProgress } from '@/lib/progress'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commented out parts that are not implemented yet

@kodiakhq kodiakhq bot merged commit 81d1d71 into main Jun 26, 2024
19 checks passed
@kodiakhq kodiakhq bot deleted the en/adjust-tips-pages branch June 26, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants