-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: moving product queries to adapter #284
Merged
joelhooks
merged 30 commits into
main
from
joel/cb-16-stripe-provider-and-product-to-adapter
Sep 3, 2024
Merged
feat: moving product queries to adapter #284
joelhooks
merged 30 commits into
main
from
joel/cb-16-stripe-provider-and-product-to-adapter
Sep 3, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@trpc/[email protected]) |
vojtaholik
approved these changes
Sep 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is great! 🚀
… and into core these things aren't next specific and should be in core
…roduct-to-adapter' into joel/cb-16-stripe-provider-and-product-to-adapter # Conflicts: # apps/pro-nextjs/src/coursebuilder/stripe-payment-adapter.ts
joelhooks
removed
the
WIP
This PR is a work in progress, not intended to be merged yet.
label
Sep 3, 2024
joelhooks
deleted the
joel/cb-16-stripe-provider-and-product-to-adapter
branch
September 3, 2024 15:13
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
requires a payment provider as well so cleaning up the stripe stuff