Docker compose standarization #19
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename compose to implicit dev name
pitastrudl
force-pushed
the
compose-standarization
branch
from
ad773a6 to
5a55846
Compare
Are there other PR's that go along with this? |
There was a problem hiding this comment.
is this .. intentional?
| badgehub-frontend: | ||
| image: ghcr.io/badgeteam/badgehub-frontend:${FRONTEND_IMAGE_TAG:-latest} | ||
| ports: | ||
| - "8001:3000" |
There was a problem hiding this comment.
How is the setup now? Does this compose file get used by the production setup? Or how is this supposed to be used?
| image: ghcr.io/badgeteam/badgehub-frontend:${FRONTEND_IMAGE_TAG:-latest} | ||
| ports: | ||
| - "8001:3000" | ||
| restart: always |
There was a problem hiding this comment.
With this restart policy, is it still possible to stop the container without deleting it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not much to add here but meaning to standardize the compose files across badgehub.