Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat support es7 #331

Open
wants to merge 3 commits into
base: 1.3.8
Choose a base branch
from
Open

Feat support es7 #331

wants to merge 3 commits into from

Conversation

Taction
Copy link
Contributor

@Taction Taction commented Feb 11, 2022

中文说明: 提交你的代码

升级es SDK,增加对es7的支持。

这是一个breaking change,目前对于没有历史数据,新起的服务是可以正常运行的。由于我对这个项目和es还不是特别熟悉,如果有什么错误或者没有考虑到的地方,希望得到指正。

@Taction
Copy link
Contributor Author

Taction commented Feb 11, 2022

另外项目的测试文件不能正常运行,看起来是有些方法签名变了,但是测试文件没有及时跟随变更。我添加了一个issue #332 追踪这个问题。

@CaledoniaProject
Copy link
Collaborator

CaledoniaProject commented Feb 11, 2022

  1. 这个支持ES 8.0、7.17嘛,你代码写死的7.11,这个得改下
  2. 数据问题不大,你可以看下是否可以用elasticdump迁移

@Taction
Copy link
Contributor Author

Taction commented Feb 11, 2022

es8.0不知道是否支持,es7.10我在本地验证过是没问题的,所以就写了7.11.我稍后试下7.17是否支持。如果支持的话,将最大版本改成8.0.0

change max version to 9.0.0 which means support 7.X and 8.X
@Taction
Copy link
Contributor Author

Taction commented Feb 12, 2022

修改了一下模板。测试了7.17和8.0.0可以正常运行。将最大版本改成了9.0.0

@CaledoniaProject CaledoniaProject changed the base branch from master to 1.3.8 February 24, 2022 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants