Pass mainnet uri as env variable to development config (#998)

* Pass mainnet uri as env variable to development config

* Check rpc url before sending request

configs/development.yml

@@ -1,6 +1,6 @@
 rpc:
   mainnet:
-    uri: https://rpc.tzkt.io/archive
+    uri: ${MAINNET_RPC_URI:-https://rpc.tzkt.io/mainnet}
     timeout: 20
     requests_per_second: 15
   ghostnet:

internal/helpers/string.go

@@ -1,7 +1,6 @@
 package helpers
 
 import (
-	"fmt"
 	"net/url"
 	"os"
 	"path"
@@ -29,13 +28,13 @@ func GenerateID() string {
 }
 
 // URLJoin -
-func URLJoin(baseURL, queryPath string) string {
+func URLJoin(baseURL, queryPath string) (string, error) {
 	u, err := url.Parse(baseURL)
 	if err != nil {
-		return fmt.Sprintf("%s/%s", baseURL, queryPath)
+		return "", err
 	}
 	u.Path = path.Join(u.Path, queryPath)
-	return u.String()
+	return u.String(), nil
 }
 
 // SpaceStringsBuilder -

internal/noderpc/rpc.go

@@ -120,7 +120,10 @@ func (rpc *NodeRPC) makeRequest(ctx context.Context, req *http.Request) (*http.R
 }
 
 func (rpc *NodeRPC) makeGetRequest(ctx context.Context, uri string) (*http.Response, error) {
-	url := helpers.URLJoin(rpc.baseURL, uri)
+	url, err := helpers.URLJoin(rpc.baseURL, uri)
+	if err != nil {
+		return nil, errors.Wrap(ErrNodeRPCError, err.Error())
+	}
 	req, err := http.NewRequestWithContext(ctx, http.MethodGet, url, nil)
 	if err != nil {
 		return nil, errors.Errorf("makeGetRequest.NewRequest: %v", err)
@@ -129,8 +132,10 @@ func (rpc *NodeRPC) makeGetRequest(ctx context.Context, uri string) (*http.Respo
 }
 
 func (rpc *NodeRPC) makePostRequest(ctx context.Context, uri string, data interface{}) (*http.Response, error) {
-	url := helpers.URLJoin(rpc.baseURL, uri)
-
+	url, err := helpers.URLJoin(rpc.baseURL, uri)
+	if err != nil {
+		return nil, errors.Wrap(ErrNodeRPCError, err.Error())
+	}
 	bData, err := json.Marshal(data)
 	if err != nil {
 		return nil, errors.Errorf("makePostRequest.json.Marshal: %v", err)