Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: wallet connect v2 #2791

Closed
wants to merge 23 commits into from
Closed

feat: wallet connect v2 #2791

wants to merge 23 commits into from

Conversation

Matthews3301
Copy link
Contributor

@Matthews3301 Matthews3301 commented Feb 10, 2023 •
edited by garethfuller
Loading

Description

Switched walletconnect/web3-provider to walletconnect/ethereum-provider. This is v2 of walletconnect which changes the modal and connection url format.

NB. there doesn't seem to be support available yet for this in the main wallets like MetaMask. V1 sunset date is 01/03/2023.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency changes
  • Code refactor / cleanup
  • Documentation or wording changes
  • Other

How should this be tested?

Please provide instructions so we can test. Please also list any relevant details for your test configuration.

  • Test A
  • Test B

Visual context

Please provide any relevant visual context for UI changes or additions. This could be static screenshots or a loom screencast.

Checklist:

  • I have performed a self-review of my own code
  • I have requested at least 1 review (If the PR is significant enough, use best judgement here)
  • I have commented my code where relevant, particularly in hard-to-understand areas
  • If package-lock.json has changes, it was intentional.
  • The base of this PR is master if hotfix, develop if not

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Feb 10, 2023 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: df41c17
Status: ✅  Deploy successful!
Preview URL: https://56c860de.balancer-d6h.pages.dev
Branch Preview URL: https://feat-wallet-connect-v2.balancer-d6h.pages.dev

View logs

@Matthews3301
Copy link
Contributor Author

Metamask support progress:
MetaMask/metamask-mobile#3957 (comment)
https://community.metamask.io/t/support-walletconnect-v2/24279

@Matthews3301
Copy link
Contributor Author

https://cloud.walletconnect.com/app/project?uuid=f7a50150-6be8-4ef6-a0b8-ff3e2c2641ed

@agualis agualis self-assigned this May 9, 2023
@agualis agualis marked this pull request as ready for review May 31, 2023 15:02
@agualis agualis marked this pull request as draft May 31, 2023 15:03
@vercel
Copy link

vercel bot commented Jun 1, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
beta-app-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 26, 2023 0:19am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
app-v2 ⬜️ Ignored (Inspect) Visit Preview Jun 26, 2023 0:19am

@agualis
Copy link
Collaborator

agualis commented Jun 28, 2023

Closed by #3581

@agualis agualis closed this Jun 28, 2023
@agualis agualis deleted the feat/wallet-connect-v2 branch June 28, 2023 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@agualis agualis

@alter-eggo alter-eggo

Labels
on hold
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Matthews3301 @agualis @garethfuller @alter-eggo