Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: sync related ui alerts on pool page #3542

Merged
merged 31 commits into from
Jun 30, 2023
Merged

feat: sync related ui alerts on pool page #3542

merged 31 commits into from
Jun 30, 2023

Conversation

alter-eggo
Copy link
Collaborator

@alter-eggo alter-eggo commented Jun 15, 2023 •
edited
Loading

Description

Add cross chain boost sync ui alerts on pool page

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency changes
  • Code refactor / cleanup
  • Documentation or wording changes
  • Other

How should this be tested?

Please provide instructions so we can test. Please also list any relevant details for your test configuration.

  • Test A
  • Test B

Visual context

Please provide any relevant visual context for UI changes or additions. This could be static screenshots or a loom screencast.

Checklist:

  • I have performed a self-review of my own code
  • I have requested at least 1 review (If the PR is significant enough, use best judgement here)
  • I have commented my code where relevant, particularly in hard-to-understand areas
  • If package-lock.json has changes, it was intentional.
  • The base of this PR is master if hotfix, develop if not

@vercel
Copy link

vercel bot commented Jun 15, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
beta-app-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 30, 2023 5:30pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
app-v2 ⬜️ Ignored (Inspect) Jun 30, 2023 5:30pm

Base automatically changed from feat/cross-chain-boost to feat/chain-boost-sync June 19, 2023 09:25
@alter-eggo alter-eggo marked this pull request as ready for review June 26, 2023 08:38
@alter-eggo alter-eggo requested review from garethfuller, timjrobinson and agualis and removed request for garethfuller and timjrobinson June 27, 2023 07:41
garethfuller
garethfuller requested changes Jun 30, 2023
View reviewed changes
src/components/_global/BalAccordion/BalAccordion.vue
@@ -17,10 +17,12 @@ type Props = {
dependencies?: unknown;
showSectionBorder?: boolean;
reCalcKey?: number;
isOpenedByDefault?: boolean;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This didn't work for me.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

src/components/contextual/pages/vebal/cross-chain-boost/StakingCardSyncAlert.vue Outdated Show resolved Hide resolved
src/components/contextual/pages/vebal/cross-chain-boost/StakingCardSyncAlert.vue Outdated Show resolved Hide resolved
src/pages/vebal.vue Show resolved Hide resolved
src/providers/cross-chain-sync.provider.ts Outdated Show resolved Hide resolved
src/providers/cross-chain-sync.provider.ts Outdated Show resolved Hide resolved
@garethfuller garethfuller merged commit 37e0d9d into feat/chain-boost-sync Jun 30, 2023
@garethfuller garethfuller deleted the feat/sync-pool-page branch June 30, 2023 18:23
garethfuller added a commit that referenced this pull request Jul 6, 2023
@alter-eggo @agualis
@pkattera @garethfuller
feat: cross chain boost sync support (#3377)
3eeb059 
* feat: add cross chain cards

* feat: add cross chain sync modal

* feat: add modal info selectors

* wip

* feat: add omni escrow request

* wip

* feat: create feature base branch

* feat: add sync state logic

* feat: add sync modals

* wip

* feat: add omni escrow voting contract

* feat: add tx error handling

* feat: add syncing network logic

* wip

* feat: add veBal balance display

* feat: add comments

* feat: add balances calculation

* feat: add sort in omni and vote escrow requests

* feat: add all unsynced state

* feat: add balances on final state

* fix: loader lint

* feat: change icons

* feat: add refetch icons

* feat: add polygon network

* feat: add temp syncing networks

* Add unit tests for useCrossChainSync

* wip

* feat: add sync refetch watcher

* feat: add cross chain sync provider

* feat: add gnosis and optimism networks

* feat: change networks icons

* feat: proper add gnosis url

* Refactor: extract useCrossChainNetwork (#3505)

* feat: add warning and info alerts

* feat: add procees to sync vebal modal

* feat: add l2 vebal balance on portfolio page

* feat: add portfolio sync tip component

* feat: app proper sync tip condition

* feat: increase sync state refetch time

* feat: change claim page texts

* feat: add boost calculation on l2s

* fix: tests

* fix: use boosts test

* feat: change refresh logic

* feat: change subgraph urls

* feat: add error alert

* feat: check tx with response mock

* fix: temp remove set to local storage

* fix: temp remove set to local storage

* feat: add clear temp sync condition

* feat: prevent memory leaking on localstorage set

* feat: remove icons

* feat: remove logs

* feat: change final state text

* feat: change l2 pools apr calc

* feat: put sync data in config

* feat: get data from configs

* fix: omni escrow locks value

* feat: add success check icon

* Fix tests

* fix: naming

* Updated network icons

* UI clean up cross chain sync

* fix: review fixes

* feat: sync related ui alerts on pool page (#3542)

* feat: add gauge balancer helper contract

* feat: add alerts in staking card

* wip

* feat: add check balances

* feat: add alerts on pool page

* wip

* feat: add user checkpoint actions

* remove logs

* feat: add networks tooltips

* feat: change sync process warning

* feat: change unstake btn style

* UI updates

* feat: change unsynced arr

* fix: unstake btn style

* feat: fix trigger update fn

* feat: open staking incentives card by default

* feat: add sync tips

* feat: opening staking incentives card

* feat: change texts

* feat: add info message

* fixes after review

---------

Co-authored-by: pkattera <[email protected]>

* chore: update wording (#3620)

* chore: Update wording

* chore: Update wording

* feat: add layer zero tx link (#3625)

* feat: add layer zero tx links

* feat: add timeout on l0 tx hashes set

* feat: hide text if no l0 link

* feat: remove test code

* feat: add padding if no link

* feat: implement fetch l0 messages on interval

* fix package lock

---------

Co-authored-by: Alberto Gualis <[email protected]>
Co-authored-by: Alberto Gualis <[email protected]>
Co-authored-by: pkattera <[email protected]>
Co-authored-by: Gareth Fuller <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pkattera pkattera pkattera left review comments

@agualis agualis Awaiting requested review from agualis

@timjrobinson timjrobinson Awaiting requested review from timjrobinson

@garethfuller garethfuller Awaiting requested review from garethfuller

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alter-eggo @garethfuller @pkattera