Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore user errors in more places #3619

Merged
merged 1 commit into from
Jul 4, 2023
Merged

Conversation

timjrobinson
Copy link
Contributor

Description

When a user rejects a join or lock transaction it still logs an error to sentry. Add additional checks for these errors to skip logging them.

Fixes https://balancer-labs.sentry.io/issues/3905587191/?project=5725878&query=is%3Aunresolved+level%3Afatal&referrer=issue-stream&statsPeriod=14d&stream_index=2

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How should this be tested?

  • Perform a join transaction and reject it when the metamask window pops up. Ensure that this rejection is not logged to Sentry

Checklist:

  • I have performed a self-review of my own code
  • I have requested at least 1 review (If the PR is significant enough, use best judgement here)
  • I have commented my code where relevant, particularly in hard-to-understand areas
  • If package-lock.json has changes, it was intentional.
  • The base of this PR is master if hotfix, develop if not

@vercel
Copy link

vercel bot commented Jul 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
beta-app-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 4, 2023 8:24am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
app-v2 ⬜️ Ignored (Inspect) Jul 4, 2023 8:24am

@timjrobinson timjrobinson merged commit 5f0b869 into develop Jul 4, 2023
@timjrobinson timjrobinson deleted the ignore-user-errors branch July 4, 2023 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants