Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Optimise pool page queries #3634

Merged
merged 4 commits into from
Jul 6, 2023

Conversation

garethfuller
Copy link
Collaborator

@garethfuller garethfuller commented Jul 5, 2023

Description

  • Uses pool provider on pool page.
  • Refactors layouts so that pool page + nested join/exit flows use the same layout and providers.
  • Optimises tokens provider to avoid running queries before vebal has been injected.
  • Optimises usePoolQuery to not wait for token injection, this used to be important when prices were also dependent on token injection.

Type of change

  • Code refactor / cleanup

How should this be tested?

  • Check network requests on pool pages.

Checklist:

  • I have performed a self-review of my own code
  • I have requested at least 1 review (If the PR is significant enough, use best judgement here)
  • I have commented my code where relevant, particularly in hard-to-understand areas
  • If package-lock.json has changes, it was intentional.
  • The base of this PR is master if hotfix, develop if not

@vercel
Copy link

vercel bot commented Jul 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
beta-app-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 5, 2023 3:12pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
app-v2 ⬜️ Ignored (Inspect) Jul 5, 2023 3:12pm

Copy link
Collaborator

@alter-eggo alter-eggo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@garethfuller garethfuller merged commit 1d88db8 into develop Jul 6, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants