Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Pass isEnabled to balance/allowance queries #3639

Merged
merged 2 commits into from
Jul 6, 2023

Conversation

garethfuller
Copy link
Collaborator

@garethfuller garethfuller commented Jul 6, 2023

Description

I introduced a bug by enabling balance/allowance queries with the query options object where it bypassed the wallet is connected check. So it was trying to fetch balances/allowances for accounts when no wallet was connected. This PR cleans up that code.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How should this be tested?

  • Check for balance fetching errors in the console, there shouldn't be any.

Checklist:

  • I have performed a self-review of my own code
  • I have requested at least 1 review (If the PR is significant enough, use best judgement here)
  • I have commented my code where relevant, particularly in hard-to-understand areas
  • If package-lock.json has changes, it was intentional.
  • The base of this PR is master if hotfix, develop if not

@vercel
Copy link

vercel bot commented Jul 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
beta-app-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 6, 2023 9:53am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
app-v2 ⬜️ Ignored (Inspect) Jul 6, 2023 9:53am

@garethfuller garethfuller requested a review from agualis July 6, 2023 09:46
@garethfuller garethfuller merged commit dd409e1 into develop Jul 6, 2023
@garethfuller garethfuller deleted the fix/query-enabling branch July 6, 2023 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants