Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix: fix zkevm voting gauges #3739

Merged
merged 1 commit into from
Jul 18, 2023
Merged

Conversation

mendesfabio
Copy link
Member

@mendesfabio mendesfabio commented Jul 18, 2023

Description

We updated the chain names on Subgraph to match on-chain gauge type names. Most of the networks didn't have issues, except zkEVM where the gauge type is different from the short name we have on config files. Since this is moving to Beets API I just made a quick fix.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency changes
  • Code refactor / cleanup
  • Documentation or wording changes
  • Other

Checklist:

  • I have performed a self-review of my own code
  • I have requested at least 1 review (If the PR is significant enough, use best judgement here)
  • I have commented my code where relevant, particularly in hard-to-understand areas
  • If package-lock.json has changes, it was intentional.
  • The base of this PR is master if hotfix, develop if not

@vercel
Copy link

vercel bot commented Jul 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
beta-app-v2 ✅ Ready (Inspect) Visit Preview Jul 18, 2023 2:13pm
1 Ignored Deployment
Name Status Preview Updated (UTC)
app-v2 ⬜️ Ignored (Inspect) Jul 18, 2023 2:13pm

@mendesfabio mendesfabio changed the title fix zkevm voting gauges hotfix: fix zkevm voting gauges Jul 18, 2023
@garethfuller
Copy link
Collaborator

@agualis not sure if you're already aware of this in the API work, tagging you in case it's relevant.

@garethfuller garethfuller merged commit 96fedf8 into master Jul 18, 2023
garethfuller added a commit that referenced this pull request Jul 18, 2023
* fix: Original error recording (#3713)

* chore: Ensure all BalActionStep errors are marked as fatal

* chore: Improve original error parsing

* 1.114.1

* Hotfix: idle/usdc whitelist (#3717)

* 1.114.2

* weekly gauges add (#3722)

* 1.114.3

* chore: Bump SDK version (#3724)

* 1.114.4

* Hotfix: Add approval check to swap (#3712)

* Use tokenApprovalActions for Swaps

Refactor swapping to use TokenApprovalActions so that it checks the user
has made their allowance high enough to swap their token.

* Rename isEthSwap to isNativeAssetSwap to be clearer for Polygon

* Make Lido rate provider work on Goerli

* Disable swap button into approvals have loaded

* 1.114.5

* hotfix: Extending Error for sentry (#3720)

* 1.114.6

* hotfix: Bump WC modal package (#3698)

* 1.114.7

* Hotfix: Re-trigger exit queries on wallet change (#3718)

* fix: Exit queries need to be retrigged if the wallet changes

* fix: Only trigger single asset max refetch on bpt balance change

* 1.114.8

* hotfix: Add metadata to cowswap errors (#3727)

* 1.114.9

* hotfix: Add metadata action as tag (#3728)

* 1.114.10

* Adding 80RATE/20WETH pool to weighted allowlist (#3729)

* 1.114.11

* hotfix: Send original error to capture (#3736)

* fix: Try to capture original error

* chore: fix lint

* 1.114.12

* hotfix: Bump SDK (#3738)

* 1.114.13

* hotfix: zkevm voting gauges (#3739)

* 1.114.14

* Fix: use stack instead of captureStackTrace

---------

Co-authored-by: Automated Version Bump <[email protected]>
Co-authored-by: ZeKraken <[email protected]>
Co-authored-by: Tim Robinson <[email protected]>
Co-authored-by: daniel <[email protected]>
Co-authored-by: oddaf <[email protected]>
Co-authored-by: Fábio Mendes <[email protected]>
Co-authored-by: Alberto Gualis <[email protected]>
garethfuller added a commit that referenced this pull request Jul 19, 2023
* fix: Original error recording (#3713)

* chore: Ensure all BalActionStep errors are marked as fatal

* chore: Improve original error parsing

* 1.114.1

* Hotfix: idle/usdc whitelist (#3717)

* 1.114.2

* weekly gauges add (#3722)

* 1.114.3

* chore: Bump SDK version (#3724)

* 1.114.4

* Hotfix: Add approval check to swap (#3712)

* Use tokenApprovalActions for Swaps

Refactor swapping to use TokenApprovalActions so that it checks the user
has made their allowance high enough to swap their token.

* Rename isEthSwap to isNativeAssetSwap to be clearer for Polygon

* Make Lido rate provider work on Goerli

* Disable swap button into approvals have loaded

* 1.114.5

* hotfix: Extending Error for sentry (#3720)

* 1.114.6

* hotfix: Bump WC modal package (#3698)

* 1.114.7

* Hotfix: Re-trigger exit queries on wallet change (#3718)

* fix: Exit queries need to be retrigged if the wallet changes

* fix: Only trigger single asset max refetch on bpt balance change

* 1.114.8

* hotfix: Add metadata to cowswap errors (#3727)

* 1.114.9

* hotfix: Add metadata action as tag (#3728)

* 1.114.10

* Adding 80RATE/20WETH pool to weighted allowlist (#3729)

* 1.114.11

* hotfix: Send original error to capture (#3736)

* fix: Try to capture original error

* chore: fix lint

* 1.114.12

* hotfix: Bump SDK (#3738)

* 1.114.13

* hotfix: zkevm voting gauges (#3739)

* 1.114.14

* fix: Prevent exit quries if amounts out are invalid e.g. 0 or gt balance

* chore: Use explicit variable for checking price impact validity

---------

Co-authored-by: Automated Version Bump <[email protected]>
Co-authored-by: ZeKraken <[email protected]>
Co-authored-by: Tim Robinson <[email protected]>
Co-authored-by: daniel <[email protected]>
Co-authored-by: oddaf <[email protected]>
Co-authored-by: Fábio Mendes <[email protected]>
garethfuller added a commit that referenced this pull request Jul 19, 2023
…s in recovery mode (dm) (#3750)

* fix: Original error recording (#3713)

* chore: Ensure all BalActionStep errors are marked as fatal

* chore: Improve original error parsing

* 1.114.1

* Hotfix: idle/usdc whitelist (#3717)

* 1.114.2

* weekly gauges add (#3722)

* 1.114.3

* chore: Bump SDK version (#3724)

* 1.114.4

* Hotfix: Add approval check to swap (#3712)

* Use tokenApprovalActions for Swaps

Refactor swapping to use TokenApprovalActions so that it checks the user
has made their allowance high enough to swap their token.

* Rename isEthSwap to isNativeAssetSwap to be clearer for Polygon

* Make Lido rate provider work on Goerli

* Disable swap button into approvals have loaded

* 1.114.5

* hotfix: Extending Error for sentry (#3720)

* 1.114.6

* hotfix: Bump WC modal package (#3698)

* 1.114.7

* Hotfix: Re-trigger exit queries on wallet change (#3718)

* fix: Exit queries need to be retrigged if the wallet changes

* fix: Only trigger single asset max refetch on bpt balance change

* 1.114.8

* hotfix: Add metadata to cowswap errors (#3727)

* 1.114.9

* hotfix: Add metadata action as tag (#3728)

* 1.114.10

* Adding 80RATE/20WETH pool to weighted allowlist (#3729)

* 1.114.11

* hotfix: Send original error to capture (#3736)

* fix: Try to capture original error

* chore: fix lint

* 1.114.12

* hotfix: Bump SDK (#3738)

* 1.114.13

* hotfix: zkevm voting gauges (#3739)

* 1.114.14

* hotfix: use stack instead of captureStackTrace (#3743)

* 1.114.15

* Change BumpTag Personal Access Token

* 1.114.16

* Fix: single token exit only allows pool tokens subset when the pool is recovery mode

* 1.114.17

* Undo last master commit

* 1.114.18

* Fix: single token exit only allows pool tokens subset when the pool is recovery mode

---------

Co-authored-by: Automated Version Bump <[email protected]>
Co-authored-by: ZeKraken <[email protected]>
Co-authored-by: Tim Robinson <[email protected]>
Co-authored-by: daniel <[email protected]>
Co-authored-by: oddaf <[email protected]>
Co-authored-by: Fábio Mendes <[email protected]>
Co-authored-by: Alberto Gualis <[email protected]>
Co-authored-by: Tim Robinson <[email protected]>
garethfuller added a commit that referenced this pull request Jul 19, 2023
* fix: Original error recording (#3713)

* chore: Ensure all BalActionStep errors are marked as fatal

* chore: Improve original error parsing

* 1.114.1

* Hotfix: idle/usdc whitelist (#3717)

* 1.114.2

* weekly gauges add (#3722)

* 1.114.3

* chore: Bump SDK version (#3724)

* 1.114.4

* Hotfix: Add approval check to swap (#3712)

* Use tokenApprovalActions for Swaps

Refactor swapping to use TokenApprovalActions so that it checks the user
has made their allowance high enough to swap their token.

* Rename isEthSwap to isNativeAssetSwap to be clearer for Polygon

* Make Lido rate provider work on Goerli

* Disable swap button into approvals have loaded

* 1.114.5

* hotfix: Extending Error for sentry (#3720)

* 1.114.6

* hotfix: Bump WC modal package (#3698)

* 1.114.7

* Hotfix: Re-trigger exit queries on wallet change (#3718)

* fix: Exit queries need to be retrigged if the wallet changes

* fix: Only trigger single asset max refetch on bpt balance change

* 1.114.8

* hotfix: Add metadata to cowswap errors (#3727)

* 1.114.9

* hotfix: Add metadata action as tag (#3728)

* 1.114.10

* Adding 80RATE/20WETH pool to weighted allowlist (#3729)

* 1.114.11

* hotfix: Send original error to capture (#3736)

* fix: Try to capture original error

* chore: fix lint

* 1.114.12

* hotfix: Bump SDK (#3738)

* 1.114.13

* hotfix: zkevm voting gauges (#3739)

* 1.114.14

* hotfix: use stack instead of captureStackTrace (#3743)

* 1.114.15

* Change BumpTag Personal Access Token

* 1.114.16

* Fix: single token exit only allows pool tokens subset when the pool is recovery mode

* 1.114.17

* Undo last master commit

* 1.114.18

* hotfix: Don't query exit if invalid amounts out (#3742)

* fix: Prevent exit quries if amounts out are invalid e.g. 0 or gt balance

* chore: Use explicit variable for checking price impact validity

* 1.114.19

* hotfix: single token exit only allows pool tokens subset when the pool is recovery mode (#3747)

* 1.114.20

* chore: Improve user rejected check

* chore: Assume the word rejected is a user rejection

---------

Co-authored-by: Automated Version Bump <[email protected]>
Co-authored-by: ZeKraken <[email protected]>
Co-authored-by: Tim Robinson <[email protected]>
Co-authored-by: daniel <[email protected]>
Co-authored-by: oddaf <[email protected]>
Co-authored-by: Fábio Mendes <[email protected]>
Co-authored-by: Alberto Gualis <[email protected]>
Co-authored-by: Tim Robinson <[email protected]>
joehquak referenced this pull request in Sobal/frontend-v2 Jul 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants