Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Lock route links #3769

Merged
merged 1 commit into from
Jul 20, 2023
Merged

fix: Lock route links #3769

merged 1 commit into from
Jul 20, 2023

Conversation

garethfuller
Copy link
Collaborator

@garethfuller garethfuller commented Jul 20, 2023 •
edited
Loading

Description

Some links to the vebal lock form page were not being properly constructed.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How should this be tested?

  • Test the lock button on ball 80/20 on goerli links to the vebal lock page.

Checklist:

  • I have performed a self-review of my own code
  • I have requested at least 1 review (If the PR is significant enough, use best judgement here)
  • I have commented my code where relevant, particularly in hard-to-understand areas
  • If package-lock.json has changes, it was intentional.
  • The base of this PR is master if hotfix, develop if not

@vercel
Copy link

vercel bot commented Jul 20, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
beta-app-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 20, 2023 0:51am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
app-v2 ⬜️ Ignored (Inspect) Jul 20, 2023 0:51am

@agualis agualis merged commit 70ff317 into master Jul 20, 2023
4 checks passed
@agualis agualis deleted the hf/fix-lock-linksd branch July 20, 2023 14:17
garethfuller added a commit that referenced this pull request Jul 21, 2023
@garethfuller @agualis @timjrobinson
Hotfix: Catch metadata collection fetching errors (dm) (#3775)
b00e68d 
* chore: Add/Update migration announcements for sfrxETH and wstETH pools (#3765)

* 1.114.29

* fix: detect and clean routes without hash (#3757)

* fix: detect and clean routes without hash

* fix: add vercel rewrites

* Improve comments

* 1.114.30

* chore: Make error more specific (#3770)

* fix: Lock route links (#3769)

* 1.114.31

* Add try/catch around collecting error metadata in case it throws

---------

Co-authored-by: Alberto Gualis <[email protected]>
Co-authored-by: Automated Version Bump <[email protected]>
Co-authored-by: Tim Robinson <[email protected]>
joehquak referenced this pull request in Sobal/frontend-v2 Jul 30, 2023
@garethfuller @joehquak
fix: Lock route links (#3769)
218e3c5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agualis agualis agualis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@garethfuller @agualis