Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix: make error more specific #3770

Merged
merged 1 commit into from
Jul 20, 2023
Merged

Hotfix: make error more specific #3770

merged 1 commit into from
Jul 20, 2023

Conversation

garethfuller
Copy link
Collaborator

Description

This error about a pool not having a preferential gauge is hard to debug and rare, I've added in the poolId so we can debug further next time it comes up.

Type of change

  • Other

Checklist:

  • I have performed a self-review of my own code
  • I have requested at least 1 review (If the PR is significant enough, use best judgement here)
  • I have commented my code where relevant, particularly in hard-to-understand areas
  • If package-lock.json has changes, it was intentional.
  • The base of this PR is master if hotfix, develop if not

@vercel
Copy link

vercel bot commented Jul 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
beta-app-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 20, 2023 1:14pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
app-v2 ⬜️ Ignored (Inspect) Jul 20, 2023 1:14pm

@agualis agualis merged commit 12e5d5b into master Jul 20, 2023
4 checks passed
@agualis agualis deleted the hf/make-error-specific branch July 20, 2023 14:17
garethfuller added a commit that referenced this pull request Jul 21, 2023
* chore: Add/Update migration announcements for sfrxETH and wstETH pools (#3765)

* 1.114.29

* fix: detect and clean routes without hash (#3757)

* fix: detect and clean routes without hash

* fix: add vercel rewrites

* Improve comments

* 1.114.30

* chore: Make error more specific (#3770)

* fix: Lock route links (#3769)

* 1.114.31

* Add try/catch around collecting error metadata in case it throws

---------

Co-authored-by: Alberto Gualis <[email protected]>
Co-authored-by: Automated Version Bump <[email protected]>
Co-authored-by: Tim Robinson <[email protected]>
joehquak referenced this pull request in Sobal/frontend-v2 Jul 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants