Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: reload pool details when pool id changes in url #3779

Merged
merged 1 commit into from
Jul 21, 2023

Conversation

agualis
Copy link
Collaborator

@agualis agualis commented Jul 21, 2023

Description

The pool provider was not being refreshed when the poolId parameter was changed in the url.

This PR enforces that the pool providers are reloaded when the route path is changed.

This fixes the navigation to new pools. Example:

https://beta-app-v2-git-fix-new-pool-links-balancer.vercel.app/#/ethereum/pool/0x5aee1e99fe86960377de9f88689616916d5dcabe000000000000000000000467

Now when we navigate to a new pool, its data is reloaded:
https://github.com/balancer/frontend-v2/assets/1316240/b469c757-b859-4d5c-96fb-ac2e2e95bed9

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency changes
  • Code refactor / cleanup
  • Documentation or wording changes
  • Other

How should this be tested?

Please provide instructions so we can test. Please also list any relevant details for your test configuration.

  • Test A
  • Test B

Visual context

Please provide any relevant visual context for UI changes or additions. This could be static screenshots or a loom screencast.

Checklist:

  • I have performed a self-review of my own code
  • I have requested at least 1 review (If the PR is significant enough, use best judgement here)
  • I have commented my code where relevant, particularly in hard-to-understand areas
  • If package-lock.json has changes, it was intentional.
  • The base of this PR is master if hotfix, develop if not

@vercel
Copy link

vercel bot commented Jul 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
beta-app-v2 ✅ Ready (Inspect) Visit Preview Jul 21, 2023 0:19am
1 Ignored Deployment
Name Status Preview Updated (UTC)
app-v2 ⬜️ Ignored (Inspect) Jul 21, 2023 0:19am

@agualis agualis merged commit fd08f8a into master Jul 21, 2023
4 checks passed
@agualis agualis deleted the fix/new-pool-links branch July 21, 2023 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants