Fix: reload pool details when pool id changes in url #3779
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The pool provider was not being refreshed when the poolId parameter was changed in the url.
This PR enforces that the pool providers are reloaded when the route path is changed.
This fixes the navigation to new pools. Example:
https://beta-app-v2-git-fix-new-pool-links-balancer.vercel.app/#/ethereum/pool/0x5aee1e99fe86960377de9f88689616916d5dcabe000000000000000000000467
Now when we navigate to a new pool, its data is reloaded:
https://github.com/balancer/frontend-v2/assets/1316240/b469c757-b859-4d5c-96fb-ac2e2e95bed9
Type of change
How should this be tested?
Please provide instructions so we can test. Please also list any relevant details for your test configuration.
Visual context
Please provide any relevant visual context for UI changes or additions. This could be static screenshots or a loom screencast.
Checklist:
master
if hotfix,develop
if not