Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upnp: Use gmrender-resurrect in place of gmrender #405

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

JodyGoldberg
Copy link

Ubuntu packages
https://github.com/hzeller/gmrender-resurrect
an updated more stable fork of gmrender

Connects-to: #342
Change-type: patch
Signed-off-by: [email protected]

Hey there, appreciated contributor!

Have you taken a look at the contribution guidelines for this project? To enable our CI to work correctly and version the releases of the project, you need to ensure your commit messages contain the required information detailed here. Thank you!

Ubuntu packages
    https://github.com/hzeller/gmrender-resurrect
an updated more stable fork of gmrender

Connects-to: balena-io-experimental#342
Change-type: patch
Signed-off-by: [email protected]
@ghost
Copy link

ghost commented Jan 20, 2021

An error occurred whilst building your landr site preview:

{
  "name": "TypeError",
  "message": "backend.getRepositoryUrl is not a function",
  "stack": "TypeError: backend.getRepositoryUrl is not a function\n    at module.exports (/usr/src/app/node_modules/scrutinizer/lib/plugins/deployButtons.js:28:33)"
}

@JodyGoldberg
Copy link
Author

How can I see what the Build failure is? A local build for pi2/3 works. Clicking on the Details link fails.

@AlexProgrammerDE AlexProgrammerDE added enhancement New feature or request upnp Everything about the upnp container labels Feb 9, 2021
@AlexProgrammerDE
Copy link
Contributor

@tmigone mind taking a look at this?

@tmigone
Copy link
Contributor

tmigone commented Feb 9, 2021

Right, so @JodyGoldberg the build is failing because we do not have ubuntu:focal images for Raspberry Pi Zero devices, we need to find a way around that.

In any case, I just read that debian packages since stretch (Debian 8) use gmrender-resurrect already instead of gmrender. So I took a look at the ubuntu focal package and it looks like it's running gmrender-resurrect v0.0.8-1 (https://packages.ubuntu.com/focal/gmediarender). Current code for balenaSound uses debian buster which uses v0.0.7 (https://packages.debian.org/buster/gmediarender). So that might be the reason you are getting better results!

What we can do is use debian bullseye which apparenty uses v0.0.9! See here: https://packages.debian.org/bullseye/gmediarender

If you can test using bullseye and confirm that it's better we can use that one, what do you think?

@drew1kun
Copy link

#342 may be related

@drew1kun drew1kun mentioned this pull request Apr 2, 2021
@JodyGoldberg
Copy link
Author

Oddly the debian packages also exhibited a fair amount of instability relative to the ubuntu but I couldn't track why. All of balena-sound has started getting finicky with client losing connection to the multi-room server. Hopefully there will be some time to dig into logs shortly to try and find root cause or at least a way to ameliorate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request upnp Everything about the upnp container
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants