spotify: Add volume control option #638
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces the option to choose the volume control method for Spotify playback by adding a new environment variable `SOUND_SPOTIFY_VOLUME_CTRL`. Users can now set the volume control method to `cubic`, `fixed`, `linear`, or `log`. The default value is set to `linear` to maintain backwards compatibility with the currently set value. Additionally, the default value for `SOUND_SPOTIFY_BITRATE` has been updated to be wrapped in backticks for better readability. Change-type: minor
timhudson
commented
Apr 18, 2023
| @@ -44,7 +46,7 @@ set -- /usr/bin/librespot \ | |||
| --name "$SOUND_DEVICE_NAME" \ | |||
| --bitrate "$SOUND_SPOTIFY_BITRATE" \ | |||
| --cache /var/cache/raspotify \ | |||
| --volume-ctrl linear \ | |||
There was a problem hiding this comment.
My subjective experience: I've found linear to be quite difficult to accurately control. I've been using cubic which provides a lot more control in lower volumes.
plisker
previously approved these changes
May 15, 2024
policy-bot-palantir-policy-bot
bot
dismissed
plisker’s stale review
Invalidated by push of 1f29863
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces the option to choose the volume control method for Spotify playback by adding a new environment variable
SOUND_SPOTIFY_VOLUME_CTRL. Users can now set the volume control method tocubic,fixed,linear, orlog. The default value is set tolinearto maintain backwards compatibility with the currently set value.Additionally, the default value for
SOUND_SPOTIFY_BITRATEhas been updated to be wrapped in backticks for better readability.Change-type: minor