Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Silence efi helpers #3419

Merged
merged 2 commits into from
Oct 8, 2024
Merged

Silence efi helpers #3419

merged 2 commits into from
Oct 8, 2024

Conversation

jakogut
Copy link
Contributor

@jakogut jakogut commented Apr 26, 2024

Contributor checklist

Reviewer Guidelines

  • When submitting a review, please pick:
    • 'Approve' if this change would be acceptable in the codebase (even if there are minor or cosmetic tweaks that could be improved).
    • 'Request Changes' if this change would not be acceptable in our codebase (e.g. bugs, changes that will make development harder in future, security/performance issues, etc).
    • 'Comment' if you don't feel you have enough information to decide either way (e.g. if you have major questions, or you don't understand the context of the change sufficiently to fully review yourself, but want to make a comment)

@jakogut jakogut requested a review from mtoman April 26, 2024 15:41
@flowzone-app flowzone-app bot enabled auto-merge April 26, 2024 15:45
@mtoman
Copy link
Contributor

mtoman commented Apr 28, 2024

lgtm

@mtoman
Copy link
Contributor

mtoman commented Apr 28, 2024

@resin-jenkins retest this please

3 similar comments
@mtoman
Copy link
Contributor

mtoman commented Apr 30, 2024

@resin-jenkins retest this please

@jakogut
Copy link
Contributor Author

jakogut commented Apr 30, 2024

@resin-jenkins retest this please

@jakogut
Copy link
Contributor Author

jakogut commented Apr 30, 2024

@resin-jenkins retest this please

@jakogut
Copy link
Contributor Author

jakogut commented May 3, 2024

@resin-jenkins retest this please

4 similar comments
@jakogut
Copy link
Contributor Author

jakogut commented May 6, 2024

@resin-jenkins retest this please

@jakogut
Copy link
Contributor Author

jakogut commented May 6, 2024

@resin-jenkins retest this please

@jakogut
Copy link
Contributor Author

jakogut commented May 8, 2024

@resin-jenkins retest this please

@jakogut
Copy link
Contributor Author

jakogut commented May 8, 2024

@resin-jenkins retest this please

@jakogut
Copy link
Contributor Author

jakogut commented Jun 5, 2024

@resin-jenkins retest this please

1 similar comment
@jakogut
Copy link
Contributor Author

jakogut commented Jun 6, 2024

@resin-jenkins retest this please

@jakogut
Copy link
Contributor Author

jakogut commented Jun 12, 2024

lgtm

@jakogut jakogut force-pushed the silence-efi-helpers branch 2 times, most recently from f96c879 to 0f1af2c Compare June 14, 2024 01:11
@jakogut
Copy link
Contributor Author

jakogut commented Jun 15, 2024

@resin-jenkins retest this please

8 similar comments
@jakogut
Copy link
Contributor Author

jakogut commented Jun 17, 2024

@resin-jenkins retest this please

@jakogut
Copy link
Contributor Author

jakogut commented Jun 19, 2024

@resin-jenkins retest this please

@jakogut
Copy link
Contributor Author

jakogut commented Jun 19, 2024

@resin-jenkins retest this please

@jakogut
Copy link
Contributor Author

jakogut commented Jun 20, 2024

@resin-jenkins retest this please

@jakogut
Copy link
Contributor Author

jakogut commented Jun 24, 2024

@resin-jenkins retest this please

@jakogut
Copy link
Contributor Author

jakogut commented Jun 24, 2024

@resin-jenkins retest this please

@jakogut
Copy link
Contributor Author

jakogut commented Jun 25, 2024

@resin-jenkins retest this please

@jakogut
Copy link
Contributor Author

jakogut commented Jun 25, 2024

@resin-jenkins retest this please

@jakogut jakogut temporarily deployed to balena-staging.com October 8, 2024 17:55 — with GitHub Actions Inactive
@jakogut jakogut temporarily deployed to balena-staging.com October 8, 2024 17:55 — with GitHub Actions Inactive
@jakogut jakogut temporarily deployed to balena-staging.com October 8, 2024 17:56 — with GitHub Actions Inactive
@jakogut jakogut temporarily deployed to balena-staging.com October 8, 2024 17:56 — with GitHub Actions Inactive
@jakogut jakogut temporarily deployed to balena-staging.com October 8, 2024 17:56 — with GitHub Actions Inactive
@jakogut jakogut temporarily deployed to balena-staging.com October 8, 2024 17:56 — with GitHub Actions Inactive
@jakogut jakogut temporarily deployed to balena-staging.com October 8, 2024 17:56 — with GitHub Actions Inactive
@jakogut jakogut temporarily deployed to balena-staging.com October 8, 2024 17:56 — with GitHub Actions Inactive
@jakogut jakogut temporarily deployed to balena-staging.com October 8, 2024 17:56 — with GitHub Actions Inactive
@jakogut jakogut temporarily deployed to balena-staging.com October 8, 2024 17:56 — with GitHub Actions Inactive
@jakogut jakogut temporarily deployed to balena-staging.com October 8, 2024 17:56 — with GitHub Actions Inactive
@jakogut jakogut temporarily deployed to balena-staging.com October 8, 2024 17:56 — with GitHub Actions Inactive
@jakogut jakogut temporarily deployed to balena-staging.com October 8, 2024 17:56 — with GitHub Actions Inactive
@jakogut jakogut temporarily deployed to balena-staging.com October 8, 2024 17:56 — with GitHub Actions Inactive
@jakogut jakogut temporarily deployed to balena-staging.com October 8, 2024 17:56 — with GitHub Actions Inactive
@jakogut jakogut temporarily deployed to balena-staging.com October 8, 2024 17:56 — with GitHub Actions Inactive
@jakogut jakogut temporarily deployed to balena-staging.com October 8, 2024 17:56 — with GitHub Actions Inactive
@jakogut jakogut temporarily deployed to balena-staging.com October 8, 2024 17:56 — with GitHub Actions Inactive
@jakogut jakogut temporarily deployed to balena-staging.com October 8, 2024 17:56 — with GitHub Actions Inactive
@flowzone-app flowzone-app bot merged commit 8048f36 into master Oct 8, 2024
157 of 159 checks passed
@flowzone-app flowzone-app bot deleted the silence-efi-helpers branch October 8, 2024 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtoman mtoman mtoman approved these changes

@alexgg alexgg alexgg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jakogut @mtoman @alexgg