Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LS API support for component deletion #480

Conversation

dulajdilshan
Copy link
Contributor

Purpose

$title

Goals

Describe the solutions that this feature/fix will introduce to resolve the problems described above

Approach

Describe how you are implementing the solutions. Include an animated GIF or screenshot if the change affects the UI (email [email protected] to review all UI text). Include a link to a Markdown file or Google doc if the feature write-up is too long to paste here.

User stories

Summary of user stories addressed by this change>

Release note

Brief description of the new feature or bug fix as it will appear in the release notes

Documentation

Link(s) to product documentation that addresses the changes of this PR. If no doc impact, enter “N/A” plus brief explanation of why there’s no doc impact

Training

Link to the PR for changes to the training content in https://github.com/wso2/WSO2-Training, if applicable

Certification

Type “Sent” when you have provided new/updated certification questions, plus four answers for each question (correct answer highlighted in bold), based on this change. Certification questions/answers should be sent to [email protected] and NOT pasted in this PR. If there is no impact on certification exams, type “N/A” and explain why.

Marketing

Link to drafts of marketing content that will describe and promote this feature, including product page changes, technical articles, blog posts, videos, etc., if applicable

Automation tests

  • Unit tests

    Code coverage information

  • Integration tests

    Details about the test cases and coverage

Security checks

Samples

Provide high-level details about the samples related to this feature

Related PRs

List any other related PRs

Migrations (if applicable)

Describe migration steps and platforms on which migration has been tested

Test environment

List all JDK versions, operating systems, databases, and browser/versions on which this feature/fix was tested

Learning

Describe the research phase and any blog posts, patterns, libraries, or add-ons you used to solve the problem.

Copy link
Contributor

@LakshanWeerasinghe LakshanWeerasinghe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we add a test where it send a JSON request containing codedata?

@dulajdilshan
Copy link
Contributor Author

Shall we add a test where it send a JSON request containing codedata?

We don't need right? It already has tests including codedata in 'deleteFlowNode' (deprecated) tests.

However, evaluating codedata part will be removed later with deprecated API

}

// Assume that the node has the following attributes: startLine, startColumn, endLine, endColumn
JsonObject jsonObject = node.getAsJsonObject();

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't we send the flow-node for all cases from the front end?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, we can't. In the Design view (Component Diagram), we don't have FlowNode information. Therefore, we implemented this. The idea is to eventually move deleteFlowNode usages to the new deleteComponent API.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK. Since we don't have flow node information for the component what is the purpose of L:120-L:123?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because, Still we have some usages in deleteFlowNode API. In the diagram we use 'deleteFlowNode' API.

Copy link
Contributor

@nipunayf nipunayf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the function is used elsewhere, are there any prompts to notify the user, or is it deleted without warning?

@nipunayf nipunayf added the Area/FlowModel Related to the flow model generation LS extension label Nov 8, 2024
@dulajdilshan
Copy link
Contributor Author

If the function is used elsewhere, are there any prompts to notify the user, or is it deleted without warning?

It deletes without warning. However, checking usability is a separate API and it needed to be called from the frontend before this.

Note: is-used API is still in progress

@LakshanWeerasinghe LakshanWeerasinghe merged commit 1a27c22 into ballerina-platform:flow_model Nov 8, 2024
3 checks passed
@dulajdilshan dulajdilshan deleted the revamp-delete-api branch November 8, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area/FlowModel Related to the flow model generation LS extension
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants