Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prompt user to update the tool based on compatibility #302

Merged
merged 6 commits into from
Jul 13, 2023

Conversation

udda1996
Copy link
Contributor

Purpose

$title

Goals

fixes #288

@udda1996 udda1996 force-pushed the prompt-tool-update branch 2 times, most recently from 22af8e4 to cd4e818 Compare June 28, 2023 05:43
@codecov
Copy link

codecov bot commented Jun 28, 2023

Codecov Report

Patch coverage: 61.40% and project coverage change: +0.21 🎉

Comparison is base (f12be0f) 61.10% compared to head (ba950e3) 61.31%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #302      +/-   ##
============================================
+ Coverage     61.10%   61.31%   +0.21%     
- Complexity      213      221       +8     
============================================
  Files            20       21       +1     
  Lines          1180     1215      +35     
  Branches        161      168       +7     
============================================
+ Hits            721      745      +24     
- Misses          369      376       +7     
- Partials         90       94       +4     
Impacted Files Coverage Δ
...ava/org/ballerinalang/command/cmd/PullCommand.java 80.00% <33.33%> (-3.34%) ⬇️
...a/org/ballerinalang/command/cmd/UpdateCommand.java 63.88% <33.33%> (-3.76%) ⬇️
.../java/org/ballerinalang/command/util/ToolUtil.java 67.82% <60.00%> (-0.39%) ⬇️
...main/java/org/ballerinalang/command/util/Tool.java 71.42% <71.42%> (ø)
...g/ballerinalang/command/cmd/UpdateToolCommand.java 53.12% <100.00%> (+1.51%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@udda1996 udda1996 force-pushed the prompt-tool-update branch 2 times, most recently from e08f8b4 to 53753dc Compare July 13, 2023 06:00
@sonarcloud
Copy link

sonarcloud bot commented Jul 13, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@udda1996 udda1996 merged commit a7b5d0c into ballerina-platform:master Jul 13, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revisit tool updating during bal dist pull <version> / bal dist update commands
2 participants