Add dependency JRE availability check before setting up the distribution #329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
udda1996
force-pushed
the
validate-dep-availability
branch
from
8293788
to
2068046
Compare
keizer619
reviewed
Oct 26, 2023
keizer619
reviewed
Oct 26, 2023
keizer619
reviewed
Oct 26, 2023
keizer619
reviewed
Oct 26, 2023
|
SonarCloud Quality Gate failed.
|
udda1996
changed the title
keizer619
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Current flow of update path is to download and setup distribution first and then download the dependency for the distribution then if required. In case if the dependency download was failed for some reason, the distribution will be available without the required dependency.
In this PR we assure that the related dependency for a distribution is available before setting up the distribution. If the distribution zip is downloaded successfully but the dependency download was interrupted, the distribution won't setup and it will not be appeared in
bal dist listas a locally available distribution. So user will need to re-run the installation commandGoals
fixes #321