Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove runtime.internal usage in tests #1678

Merged

Conversation

dilanSachi
Copy link
Contributor

@dilanSachi dilanSachi commented Jun 22, 2023

Purpose

$subject
Related to ballerina-platform/ballerina-library#4607

Examples

Checklist

  • Linked to an issue
  • Updated the changelog
  • Added tests
  • Updated the spec
  • Checked native-image compatibility

@sonarcloud
Copy link

sonarcloud bot commented Jun 22, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@dilanSachi dilanSachi added the Skip GraalVM Check This will skip the GraalVM compatibility check label Jun 22, 2023
@codecov
Copy link

codecov bot commented Jun 22, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.05 🎉

Comparison is base (e06f603) 81.57% compared to head (889f1ab) 81.63%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1678      +/-   ##
============================================
+ Coverage     81.57%   81.63%   +0.05%     
  Complexity      577      577              
============================================
  Files           393      393              
  Lines         21395    21395              
  Branches       4790     4790              
============================================
+ Hits          17453    17465      +12     
+ Misses         2947     2933      -14     
- Partials        995      997       +2     

see 8 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dilanSachi dilanSachi marked this pull request as ready for review June 22, 2023 08:28
@dilanSachi dilanSachi removed the Skip GraalVM Check This will skip the GraalVM compatibility check label Jun 30, 2023
@TharmiganK TharmiganK merged commit c0c77e0 into ballerina-platform:master Jul 6, 2023
@dilanSachi dilanSachi deleted the remove-runtime-internal branch July 9, 2023 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants